This is an archive of the discontinued LLVM Phabricator instance.

[libc++][CI] Fixes error messages.
ClosedPublic

Authored by Mordante on Aug 11 2023, 11:19 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rG2c629eb5087a: [libc++][CI] Fixes error messages.
Summary

Fixes 2 error messages from the module test clang-tidy plugin.

  • an issue where an empty filename can't be used in an AST matcher
  • an issue where no filename is valid when testing the std module cppm

This reduces the output of the test, making it easier to find the real
error when the test fails.

Diff Detail

Event Timeline

Mordante created this revision.Aug 11 2023, 11:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2023, 11:19 AM
Mordante requested review of this revision.Aug 11 2023, 11:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2023, 11:19 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision.Aug 16 2023, 11:17 AM

Could you add a short description of what this suppresses to the commit message?

This revision is now accepted and ready to land.Aug 16 2023, 11:17 AM

Could you add a short description of what this suppresses to the commit message?

Good point, seems I forgot that.

Mordante edited the summary of this revision. (Show Details)Aug 17 2023, 9:08 AM
This revision was landed with ongoing or failed builds.Aug 17 2023, 9:09 AM
This revision was automatically updated to reflect the committed changes.