This is an archive of the discontinued LLVM Phabricator instance.

Differential D157642

flang: Fix module-debug-file-loc-linux.f90 in standalone
ClosedPublic

Authored by tuliom on Aug 10 2023, 12:28 PM.

Details

Reviewers
kiranchandramohan
Group Reviewers
Restricted Project
Commits
rG94f377d88037: flang: Fix module-debug-file-loc-linux.f90 in standalone
Summary

flang: Fix module-debug-file-loc-linux.f90 in standalone

In a standalone build, there is no guarantee that flang code would be
saved in a directory named flang. Check only the path under flang's root
directory.

Diff Detail

Event Timeline

tuliom created this revision.Aug 10 2023, 12:28 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 10 2023, 12:28 PM
tuliom requested review of this revision.Aug 10 2023, 12:28 PM
Herald added a subscriber: jdoerfert. · View Herald TranscriptAug 10 2023, 12:28 PM
Harbormaster completed remote builds in B251763: Diff 549136.Aug 10 2023, 5:21 PM
tuliom added a reviewer: Restricted Project.Aug 11 2023, 4:41 AM
kiranchandramohan accepted this revision.Aug 11 2023, 4:48 AM
kiranchandramohan added a subscriber: kiranchandramohan.

LG

This revision is now accepted and ready to land.Aug 11 2023, 4:48 AM
Closed by commit rG94f377d88037: flang: Fix module-debug-file-loc-linux.f90 in standalone (authored by tuliom). · Explain WhyAug 14 2023, 6:23 AM
This revision was automatically updated to reflect the committed changes.
tuliom added a commit: rG94f377d88037: flang: Fix module-debug-file-loc-linux.f90 in standalone.

Revision Contents

PathSize
flang/
test/
Lower/
2 lines

Diff 549903

flang/test/Lower/module-debug-file-loc-linux.f90

! Test that the module has the location information ! Test that the module has the location information
! RUN: %flang_fc1 -mmlir --mlir-print-debuginfo -emit-fir -o - %s | FileCheck %s ! RUN: %flang_fc1 -mmlir --mlir-print-debuginfo -emit-fir -o - %s | FileCheck %s
! REQUIRES: system-linux ! REQUIRES: system-linux
subroutine sb1() subroutine sb1()
end subroutine end subroutine
! CHECK: module attributes ! CHECK: module attributes
! CHECK: func.func @_QPsb1() { ! CHECK: func.func @_QPsb1() {
! CHECK: } ! CHECK: }
! CHECK: } loc(#[[MODULE_LOC:.*]]) ! CHECK: } loc(#[[MODULE_LOC:.*]])
! CHECK: #[[MODULE_LOC]] = loc("/{{.*}}flang/test/Lower/module-debug-file-loc-linux.f90":0:0) ! CHECK: #[[MODULE_LOC]] = loc("/{{.*}}/test/Lower/module-debug-file-loc-linux.f90":0:0)