[lldb][test] Remove tests relying on deprecated std::char_traits specializations

[Michael137]

Summary

(motivated by test failures after D157058)

With D157058 the base template for std::char_traits was removed from
libc++. Quoting the release notes:

The base template for ``std::char_traits`` has been removed. If you are using
``std::char_traits`` with types other than ``char``, ``wchar_t``, ``char8_t``,
``char16_t``, ``char32_t`` or a custom character type for which you
specialized ``std::char_traits``, your code will no longer work.

This patch simply removes all such instantiations to make sure the
tests that run against the latest libc++ version pass.

One could try testing the existence of this base template from within
the test source files but this doesn't seem like something we want
support.

[JDevlieghere]

If this was important we could put this behind a define, break up the test and conditionally skip it based on the libc++ version. But I personally don't think that's worth it for this. LGTM.

[gribozavr2]

Thank you!

lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string/TestDataFormatterLibcxxString.py

def test_with_run_command(self):
 
         is_64_bit = self.process().GetAddressByteSize() == 8
 
         # Execute the cleanup function during test case tear down.
         self.addTearDownHook(cleanup)
 
         ns = self.namespace
 
-        if self.expectedCompiler(["clang"]) and self.expectedCompilerVersion(
-            [">", "16.0"]
-        ):
-            expected_basic_string = "%s::basic_string<unsigned char>" % ns
-        else:
-            expected_basic_string = (
-                "%s::basic_string<unsigned char, %s::char_traits<unsigned char>, "
-                "%s::allocator<unsigned char> >" % (ns, ns, ns)
-            )
-
         self.expect(
             "frame variable",
             substrs=[
                 '(%s::wstring) wempty = L""' % ns,
                 '(%s::wstring) s = L"hello world! מזל טוב!"' % ns,
                 '(%s::wstring) S = L"!!!!"' % ns,
                 "(const wchar_t *) mazeltov = 0x",
                 'L"מזל טוב"',
                 '(%s::string) empty = ""' % ns,
                 '(%s::string) q = "hello world"' % ns,
                 '(%s::string) Q = "quite a long std::strin with lots of info inside it"'
                 % ns,
                 '(%s::string) IHaveEmbeddedZeros = "a\\0b\\0c\\0d"' % ns,
                 '(%s::wstring) IHaveEmbeddedZerosToo = L"hello world!\\0てざ ル゜䋨ミ㠧槊 きゅへ狦穤襩 じゃ馩リョ 䤦監"'
                 % ns,
                 '(%s::u16string) u16_string = u"ß水氶"' % ns,
                 # FIXME: This should have a 'u' prefix.
                 '(%s::u16string) u16_empty = ""' % ns,
                 '(%s::u32string) u32_string = U"🍄🍅🍆🍌"' % ns,
                 # FIXME: This should have a 'U' prefix.
                 '(%s::u32string) u32_empty = ""' % ns,
-                '(%s) uchar = "aaaaa"' % expected_basic_string,
                 "(%s::string *) null_str = nullptr" % ns,
             ],
         )
 
         thread.StepOver()
 
         TheVeryLongOne = frame.FindVariable("TheVeryLongOne")
         summaryOptions = lldb.SBTypeSummaryOptions()
def test_with_run_command(self):
                 '(%s::string) Q = "quite a long std::strin with lots of info inside it"'
                 % ns,
                 '(%s::string) IHaveEmbeddedZeros = "a\\0b\\0c\\0d"' % ns,
                 '(%s::wstring) IHaveEmbeddedZerosToo = L"hello world!\\0てざ ル゜䋨ミ㠧槊 きゅへ狦穤襩 じゃ馩リョ 䤦監"'
                 % ns,
                 '(%s::u16string) u16_string = u"ß水氶"' % ns,
                 '(%s::u32string) u32_string = U"🍄🍅🍆🍌"' % ns,
                 '(%s::u32string) u32_empty = ""' % ns,
-                '(%s) uchar = "aaaaa"' % expected_basic_string,
                 "(%s::string *) null_str = nullptr" % ns,
             ],
         )
 
         # The test assumes that std::string is in its cap-size-data layout.
         is_alternate_layout = (
             "arm" in self.getArchitecture()
         ) and self.platformIsDarwin()

lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string/main.cpp

int main()
     std::string Q("quite a long std::strin with lots of info inside it");
     std::string TheVeryLongOne("1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890someText1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890");
     std::string IHaveEmbeddedZeros("a\0b\0c\0d",7);
     std::wstring IHaveEmbeddedZerosToo(L"hello world!\0てざ ル゜䋨ミ㠧槊 きゅへ狦穤襩 じゃ馩リョ 䤦監", 38);
     std::u16string u16_string(u"ß水氶");
     std::u16string u16_empty(u"");
     std::u32string u32_string(U"🍄🍅🍆🍌");
     std::u32string u32_empty(U"");
-    std::basic_string<unsigned char> uchar(5, 'a');
     std::string *null_str = nullptr;
 
     std::string garbage1, garbage2, garbage3, garbage4, garbage5;
     if (sizeof(std::string) == sizeof(garbage_string_short_mode))
       memcpy((void *)&garbage1, &garbage_string_short_mode, sizeof(std::string));
     if (sizeof(std::string) == sizeof(garbage_string_long_mode1))
       memcpy((void *)&garbage2, &garbage_string_long_mode1, sizeof(std::string));
     if (sizeof(std::string) == sizeof(garbage_string_long_mode2))

lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string_view/TestDataFormatterLibcxxStringView.py

def test_with_run_command(self):
             self.runCmd("type summary clear", check=False)
             self.runCmd("type filter clear", check=False)
             self.runCmd("type synth clear", check=False)
             self.runCmd("settings set target.max-children-count 256", check=False)
 
         # Execute the cleanup function during test case tear down.
         self.addTearDownHook(cleanup)
 
-        if self.expectedCompiler(["clang"]) and self.expectedCompilerVersion(
-            [">", "16.0"]
-        ):
-            expected_basic_string = "std::basic_string<unsigned char>"
-            expected_basic_string_view = "std::basic_string_view<unsigned char>"
-        else:
-            expected_basic_string = "std::basic_string<unsigned char, std::char_traits<unsigned char>, std::allocator<unsigned char> >"
-            expected_basic_string_view = "std::basic_string_view<unsigned char, std::char_traits<unsigned char> >"
-
         self.expect_var_path("wempty", type="std::wstring_view", summary='L""')
         self.expect_var_path(
             "s", type="std::wstring_view", summary='L"hello world! מזל טוב!"'
         )
         self.expect_var_path("S", type="std::wstring_view", summary='L"!!!!"')
         self.expect_var_path("empty", type="std::string_view", summary='""')
         self.expect_var_path("q_source", type="std::string", summary='"hello world"')
         self.expect_var_path("q", type="std::string_view", summary='"hello world"')
def test_with_run_command(self):
         )
         self.expect_var_path("u16_string", type="std::u16string_view", summary='u"ß水氶"')
         self.expect_var_path("u16_empty", type="std::u16string_view", summary='""')
         self.expect_var_path(
             "u32_string", type="std::u32string_view", summary='U"🍄🍅🍆🍌"'
         )
         self.expect_var_path("u32_empty", type="std::u32string_view", summary='""')
         self.expect_var_path(
-            "uchar_source", type=expected_basic_string, summary='"aaaaaaaaaa"'
-        )
-        self.expect_var_path(
-            "uchar", type=expected_basic_string_view, summary='"aaaaa"'
-        )
-        self.expect_var_path(
             "oops", type="std::string_view", summary='"Hellooo World\\n"'
         )
 
         # GetSummary returns None so can't be checked by expect_var_path, so we
         # use the str representation instead
         null_obj = self.frame().GetValueForVariablePath("null_str")
         self.assertEqual(null_obj.GetSummary(), "Summary Unavailable")
         self.assertEqual(str(null_obj), "(std::string_view *) null_str = nullptr")
def test_with_run_command(self):
             summary='L"hello world!\\0てざ ル゜䋨ミ㠧槊 きゅへ狦穤襩 じゃ馩リョ 䤦監"',
         )
         self.expect_var_path("u16_string", type="std::u16string_view", summary='u"ß水氶"')
         self.expect_var_path("u16_empty", type="std::u16string_view", summary='""')
         self.expect_var_path(
             "u32_string", type="std::u32string_view", summary='U"🍄🍅🍆🍌"'
         )
         self.expect_var_path("u32_empty", type="std::u32string_view", summary='""')
-        self.expect_var_path(
-            "uchar_source", type=expected_basic_string, summary='"aaaaaaaaaa"'
-        )
-        self.expect_var_path(
-            "uchar", type=expected_basic_string_view, summary='"aaaaa"'
-        )
 
         self.runCmd("cont")
         self.expect(
             "thread list",
             STOPPED_DUE_TO_BREAKPOINT,
             substrs=["stopped", "stop reason = breakpoint"],
         )
 
         broken_obj = self.frame().GetValueForVariablePath("in_str_view")
         self.assertEqual(broken_obj.GetSummary(), "Summary Unavailable")

lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string_view/main.cpp

std::string_view TheVeryLongOne(
       "1234567890123456789012345678901234567890");
   std::string_view IHaveEmbeddedZeros("a\0b\0c\0d", 7);
   std::wstring_view IHaveEmbeddedZerosToo(
       L"hello world!\0てざ ル゜䋨ミ㠧槊 きゅへ狦穤襩 じゃ馩リョ 䤦監", 38);
   std::u16string_view u16_string(u"ß水氶");
   std::u16string_view u16_empty(u"");
   std::u32string_view u32_string(U"🍄🍅🍆🍌");
   std::u32string_view u32_empty(U"");
-  std::basic_string<unsigned char> uchar_source(10, 'a');
-  std::basic_string_view<unsigned char> uchar(uchar_source.data(), 5);
   std::string_view *null_str = nullptr;
 
   std::string hello = "Hellooo ";
   std::string_view oops = hello + "World\n";
 
   q_source[0] = 'H'; // Set break point at this line.
 
   std::string_view *not_a_string_view = nullptr;
   touch_string(*not_a_string_view);
 
   return 0;
 }

lldb/test/API/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/TestDataFormatterStdString.py

def test_with_run_command(self):
         var_empty = self.frame().FindVariable("empty")
         var_q = self.frame().FindVariable("q")
         var_Q = self.frame().FindVariable("Q")
         var_rq = self.frame().FindVariable("rq")
         var_rQ = self.frame().FindVariable("rQ")
         var_pq = self.frame().FindVariable("pq")
         var_pQ = self.frame().FindVariable("pQ")
 
-        var_uchar = self.frame().FindVariable("uchar")
-
         self.assertEqual(var_wempty.GetSummary(), 'L""', "wempty summary wrong")
         self.assertEqual(
             var_s.GetSummary(), 'L"hello world! מזל טוב!"', "s summary wrong"
         )
         self.assertEqual(var_S.GetSummary(), 'L"!!!!"', "S summary wrong")
         self.assertEqual(
             var_mazeltov.GetSummary(), 'L"מזל טוב"', "mazeltov summary wrong"
         )
         self.assertEqual(var_empty.GetSummary(), '""', "empty summary wrong")
         self.assertEqual(var_q.GetSummary(), '"hello world"', "q summary wrong")
         self.assertEqual(
             var_Q.GetSummary(),
             '"quite a long std::strin with lots of info inside it"',
             "Q summary wrong",
         )
-        self.assertEqual(var_uchar.GetSummary(), '"aaaaa"', "u summary wrong")
         self.assertEqual(var_rq.GetSummary(), '"hello world"', "rq summary wrong")
         self.assertEqual(
             var_rQ.GetSummary(),
             '"quite a long std::strin with lots of info inside it"',
             "rQ summary wrong",
         )
         self.assertEqual(var_pq.GetSummary(), '"hello world"', "pq summary wrong")
         self.assertEqual(
             var_pQ.GetSummary(),
             '"quite a long std::strin with lots of info inside it"',
             "pQ summary wrong",
         )
 
         self.runCmd("next")
 
         self.assertEqual(var_S.GetSummary(), 'L"!!!!!"', "new S summary wrong")

lldb/test/API/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/main.cpp

 #include <string>
 
 int main()
 {
     std::wstring wempty(L"");
     std::wstring s(L"hello world! מזל טוב!");
     std::wstring S(L"!!!!");
     const wchar_t *mazeltov = L"מזל טוב";
     std::string empty("");
     std::string q("hello world");
     std::string Q("quite a long std::strin with lots of info inside it");
-    std::basic_string<unsigned char> uchar(5, 'a');
     auto &rq = q, &rQ = Q;
     std::string *pq = &q, *pQ = &Q;
     S.assign(L"!!!!!"); // Set break point at this line.
     return 0;
 }