Fix "use after move" in iterator_range

[andrew.w.kaylor]

Summary

A static analysis tool reported a "use after move" error in a place where the same object was being passed to two different calls using std::forward. While this seems unlikely to present an actual problem, removing the std::forward makes the code slightly more robust.

This is an update to D152891.

[steakhal]

Please have a link to the inline discussion where you originally raised this.
Also, make sure everything still complies and monitor if you need to revert once you merged the change.

llvm/include/llvm/ADT/iterator_range.h

#if __GNUC__ == 7
   // See https://github.com/llvm/llvm-project/issues/63843
   template <typename Container>
 #else
   template <typename Container,
             std::enable_if_t<explicitly_convertible<
                 detail::IterOfRange<Container>, IteratorT>::value> * = nullptr>
 #endif
   iterator_range(Container &&c)
-      : begin_iterator(adl_begin(std::forward<Container>(c))),
-        end_iterator(adl_end(std::forward<Container>(c))) {
+      : begin_iterator(adl_begin(c)), end_iterator(adl_end(c)) {
   }
   iterator_range(IteratorT begin_iterator, IteratorT end_iterator)
       : begin_iterator(std::move(begin_iterator)),
         end_iterator(std::move(end_iterator)) {}
 
   IteratorT begin() const { return begin_iterator; }
   IteratorT end() const { return end_iterator; }
   bool empty() const { return begin_iterator == end_iterator; }