This is an archive of the discontinued LLVM Phabricator instance.

[include-cleaner] Dont boost private headers beyond public ones
ClosedPublic

Authored by kadircet on Aug 8 2023, 8:02 AM.

Details

Summary

Private headers should be the last resort, even if they match the name
of a symbol. It's pretty common in umrella headers to have internal file names
that match the symbol (e.g. Eigen::Matrix, declared in private header Matrix.h,
and exposed in umbrella header Eigen/Core).

Diff Detail

Event Timeline

kadircet created this revision.Aug 8 2023, 8:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2023, 8:02 AM
kadircet requested review of this revision.Aug 8 2023, 8:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2023, 8:02 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
VitaNuo accepted this revision.Aug 8 2023, 9:03 AM

Thanks.

clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp
474

nit: would be better to split this into multiple lines.

This revision is now accepted and ready to land.Aug 8 2023, 9:03 AM