[clang] Added Attr::getVariety function

[strimo378]

Summary

The commit extends ClangAttrEmitter of tablegen to generate Attr*::getVariety() functions. The functions returns the variety of the attribute as an enum. I'll use the function in a follow up commit to improve the output of function attributes for ast-print.

[aaron.ballman]

clang/include/clang/AST/Attr.h

87–99

I don't think either of these are needed -- Attr inherits from AttributeCommonInfo and that base class already has AttributeCommonInfo::getSyntax() for getting this information. Will that work for your needs?

[strimo378]

@aaron.ballman Thank you for the information. Strange that I missed that ... I even used the function somewhere else o_O

[strimo378]

Using Attr::getSyntax (instead of unnecessary added Attr::getVariety)

[strimo378]

Unnecessary

clang/include/clang/AST/Attr.h

 public:
   attr::Kind getKind() const { return static_cast<attr::Kind>(AttrKind); }
 
   unsigned getSpellingListIndex() const {
     return getAttributeSpellingListIndex();
   }
   const char *getSpelling() const;
 
+  enum class Variety {
+    None,
+    GNU,          // __attribute__((...))
+    Declspec,     // __declspec(...)
+    Microsoft,    // [...]
+    CXX11,        // [[...]]
+    C2x,          // [[...]]
+    Keyword,      // e.g. _Noreturn, final, __fastcall, etc.
+    Pragma,       // #pragma ...
+    HLSLSemantic, // :...
+  };
+
+  Variety getVariety() const;
+
   SourceLocation getLocation() const { return getRange().getBegin(); }
 
   bool isInherited() const { return Inherited; }
 
   /// Returns true if the attribute has been implicitly created instead
   /// of explicitly written by the user.
   bool isImplicit() const { return Implicit; }
   void setImplicit(bool I) { Implicit = I; }

clang/utils/TableGen/ClangAttrEmitter.cpp

for (unsigned I = 0; I < Spellings.size(); ++I)
     OS << "  case " << I << ":\n"
           "    return \"" << Spellings[I].name() << "\";\n";
   // End of the switch statement.
   OS << "  }\n";
   // End of the getSpelling function.
   OS << "}\n\n";
 }
 
+static void writeGetVarietyFunction(const Record &R, raw_ostream &OS) {
+  std::vector<FlattenedSpelling> Spellings = GetFlattenedSpellings(R);
+
+  OS << "Attr::Variety " << R.getName() << "Attr::getVariety() const {\n";
+  if (Spellings.empty()) {
+    OS << "  return Variety::None;\n}\n\n";
+    return;
+  }
+
+  OS << "  switch (getAttributeSpellingListIndex()) {\n"
+        "  default:\n"
+        "    llvm_unreachable(\"Unknown attribute spelling!\");\n"
+        "    return Variety::None;\n";
+
+  for (unsigned I = 0; I < Spellings.size(); ++I) {
+    OS << "  case " << I << ":\n";
+    OS << "    return Variety::" << Spellings[I].variety() << ";\n";
+  }
+  // End of the switch statement.
+  OS << "  }\n";
+  // End of the getVariety function.
+  OS << "}\n\n";
+}
+
 static void
 writePrettyPrintFunction(const Record &R,
                          const std::vector<std::unique_ptr<Argument>> &Args,
                          raw_ostream &OS) {
   std::vector<FlattenedSpelling> Spellings = GetFlattenedSpellings(R);
 
   OS << "void " << R.getName() << "Attr::printPretty("
     << "raw_ostream &OS, const PrintingPolicy &Policy) const {\n";
if (DelayedArgs && HasRequiredArgs)
       emitCtor(false, false, true);
 
     if (Header) {
       OS << '\n';
       OS << "  " << R.getName() << "Attr *clone(ASTContext &C) const;\n";
       OS << "  void printPretty(raw_ostream &OS,\n"
          << "                   const PrintingPolicy &Policy) const;\n";
       OS << "  const char *getSpelling() const;\n";
+      OS << "  Variety getVariety() const;\n";
     }
 
     if (!ElideSpelling) {
       assert(!SemanticToSyntacticMap.empty() && "Empty semantic mapping list");
       if (Header)
         OS << "  Spelling getSemanticSpelling() const;\n";
       else {
         OS << R.getName() << "Attr::Spelling " << R.getName()
if (Header) {
         OS << "  A->setDelayedArgs(C, ";
         DelayedArgs->writeCloneArgs(OS);
         OS << ");\n";
       }
       OS << "  return A;\n}\n\n";
 
       writePrettyPrintFunction(R, Args, OS);
       writeGetSpellingFunction(R, OS);
+      writeGetVarietyFunction(R, OS);
     }
   }
 }
 // Emits the class definitions for attributes.
 void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) {
   emitSourceFileHeader("Attribute classes' definitions", OS);
 
   OS << "#ifndef LLVM_CLANG_ATTR_CLASSES_INC\n";
void clang::EmitClangAttrImpl(RecordKeeper &Records, raw_ostream &OS) {
   };
 
   OS << "const char *Attr::getSpelling() const {\n";
   EmitFunc("getSpelling()");
 
   OS << "Attr *Attr::clone(ASTContext &C) const {\n";
   EmitFunc("clone(C)");
 
+  OS << "Attr::Variety Attr::getVariety() const {\n";
+  EmitFunc("getVariety()");
+
   OS << "void Attr::printPretty(raw_ostream &OS, "
         "const PrintingPolicy &Policy) const {\n";
   EmitFunc("printPretty(OS, Policy)");
 }
 
 static void emitAttrList(raw_ostream &OS, StringRef Class,
                          const std::vector<Record*> &AttrList) {
   for (auto Cur : AttrList) {