Page MenuHomePhabricator

Remove setting of inlinehint and cold attributes based on profile data
ClosedPublic

Authored by eraman on Dec 22 2015, 1:49 PM.

Details

Summary

NFC. These hints are only used for inlining and the inliner now uses the same criteria to identify hot and cold callees and set appropriate thresholds without relying on these hints. Hence this removed code is superfluous.

Diff Detail

Repository
rL LLVM

Event Timeline

eraman updated this revision to Diff 43479.Dec 22 2015, 1:49 PM
eraman retitled this revision from to Remove setting of inlinehint and cold attributes based on profile data.
eraman updated this object.
eraman added reviewers: bogner, davidxl.
eraman added a subscriber: cfe-commits.
davidxl edited edge metadata.Dec 22 2015, 2:49 PM

This looks like a straightforward cleanup (the test cases have been in a previous patch).

davidxl accepted this revision.Dec 30 2015, 9:41 AM
davidxl edited edge metadata.

lgtm

This revision is now accepted and ready to land.Dec 30 2015, 9:41 AM
This revision was automatically updated to reflect the committed changes.