This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Fix ThreadList::Update not locking the rhs's mutex
ClosedPublic

Authored by augusto2112 on Aug 4 2023, 4:01 PM.

Details

Summary

ThreadList::Update is being caught by thread sanitizer. There's even a
comment on the function that both mutexes should be lock (even though
only the "this" mutex was actually being locked). Fix this by locking
both mutexes.

Diff Detail

Event Timeline

augusto2112 created this revision.Aug 4 2023, 4:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2023, 4:01 PM
augusto2112 requested review of this revision.Aug 4 2023, 4:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2023, 4:01 PM
This revision is now accepted and ready to land.Aug 4 2023, 4:02 PM