This is an archive of the discontinued LLVM Phabricator instance.

[ELF] - improved relocation-copy.s test (added R_X86_64_32 relocations)
ClosedPublic

Authored by grimar on Dec 22 2015, 6:24 AM.

Details

Summary
  • Added instructions to generate R_X86_64_32 relocations. Without that next part of code was uncovered by test, code worked without it:
bool X86_64TargetInfo::relocNeedsPlt(uint32_t Type, const SymbolBody &S) const {
  if (needsCopyRel(Type, S))
    return false;
  • Removed -e main, added _start

Diff Detail

Event Timeline

grimar updated this revision to Diff 43443.Dec 22 2015, 6:24 AM
grimar retitled this revision from to [ELF] - improved relocation-copy.s test (added R_X86_64_32 relocations).
grimar updated this object.
grimar added reviewers: ruiu, rafael.
grimar added subscribers: llvm-commits, grimar.
ruiu accepted this revision.Jan 8 2016, 2:38 PM
ruiu edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jan 8 2016, 2:38 PM
This revision was automatically updated to reflect the committed changes.