[lldb/crashlog] Skip images with empty path and 0 UUID from loading

[mib]

Summary

This patch skips images with an empty path or a 0 UUID from loading as a
SymbolFileJSON.

rdar://112107986

Signed-off-by: Med Ismail Bennani <[e-mail]>

[bulbazord]

lldb/examples/python/symbolication.py

416–417

It looks like name is only used below on line 435 to create obj_file, so you could move that computation down there and check the validity of self.path instead. Does that work? Or am I missing something?

Also, it seems like you might want to do this chunk of work at the beginning of the function to make sure you have a valid image before you try to process it? Is there an edge case where we'd still want to process a module with a UUID of 0 and no path?

[mib]

Address @bulbazord comments.

[bulbazord]

LGTM

[JDevlieghere]

Test?

lldb/examples/python/symbolication.py

def load_module(self, target):
                     return "error: invalid module"
             else:
                 return "error: invalid target"
         else:
             return "error: no section infos"
 
     def add_module(self, target, obj_dir=None):
         """Add the Image described in this object to "target" and load the sections if "load" is True."""
+        if not self.path and self.uuid == uuid.UUID(int=0):
+            return "error: invalid image"
+
         if target:
             # Try and find using UUID only first so that paths need not match
             # up
             uuid_str = self.get_normalized_uuid_string()
             if uuid_str:
                 self.module = target.AddModule(None, None, uuid_str)
             if not self.module and self.resolve:
                 self.locate_module_and_debug_symbols()
                 if not self.unavailable:
                     resolved_path = self.get_resolved_path()
                     self.module = target.AddModule(
                         resolved_path, None, uuid_str, self.symfile
                     )
             if not self.module and self.section_infos:
                 name = os.path.basename(self.path)
                 if obj_dir and os.path.isdir(obj_dir):
                     data = {
                         "triple": target.triple,
                         "uuid": uuid_str,
                         "type": "sharedlibrary",
                         "sections": list(),
                         "symbols": list(),
                     }
                     for section in self.section_infos: