This is an archive of the discontinued LLVM Phabricator instance.

[BPF] Match CHECK w/ LLVM_ENABLE_ASSERTIONS=OFF
ClosedPublic

Authored by tamird on Jul 31 2023, 6:34 PM.

Details

Reviewers
chapuni
Summary

Fixes a test failure when built with assertions disabled.

Original breakage in d542a56c (https://reviews.llvm.org/D156136).

Diff Detail

Unit TestsFailed

Event Timeline

tamird created this revision.Jul 31 2023, 6:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2023, 6:34 PM
tamird requested review of this revision.Jul 31 2023, 6:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2023, 6:35 PM
chapuni accepted this revision.Jul 31 2023, 6:52 PM

Thanks. I assume you have tested in both configurations.

  • Better to mention the original commit as D156136 (or commit hash) in the commit log.
  • You may also fix and recommit in the previous diff D156136.
This revision is now accepted and ready to land.Jul 31 2023, 6:52 PM
tamird updated this revision to Diff 545898.Jul 31 2023, 7:01 PM

Reference original review.

Thanks. I assume you have tested in both configurations.

Yes I did.

  • Better to mention the original commit as D156136 (or commit hash) in the commit log.
  • You may also fix and recommit in the previous diff D156136.

Done.

tamird edited the summary of this revision. (Show Details)Jul 31 2023, 7:02 PM

Are you able to merge this for me? I lack the necessary access.

chapuni closed this revision.Jul 31 2023, 7:18 PM

Done in rG59afd298996c

Oh excuse me, I've forgot adding the phab ID in my commit.
(I don't use arcanist for committing)