This is an archive of the discontinued LLVM Phabricator instance.

Differential D156462

[test-suite] Fix custom section test on MachO Platforms
ClosedPublic

Authored by steven_wu on Jul 27 2023, 10:34 AM.

Download Raw Diff

Details

Reviewers

daltenty
hubert.reinterpretcast

Commits

rTc37b4205b122: [test-suite] Fix custom section test on MachO Platforms

Summary

Fix the tests added in https://reviews.llvm.org/D154673 to work on apple
platforms.

Diff Detail

Repository: rT test-suite

Event Timeline

steven_wu created this revision.Jul 27 2023, 10:34 AM

Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2023, 10:34 AM

Herald added a subscriber: ributzka. · View Herald Transcript

steven_wu requested review of this revision.Jul 27 2023, 10:34 AM

Harbormaster completed remote builds in B248633: Diff 544850.Jul 27 2023, 10:34 AM

LGTM, thanks for the fix!

This revision is now accepted and ready to land.Jul 27 2023, 12:14 PM

Closed by commit rTc37b4205b122: [test-suite] Fix custom section test on MachO Platforms (authored by steven_wu). · Explain WhyJul 27 2023, 12:30 PM

This revision was automatically updated to reflect the committed changes.

steven_wu added a commit: rTc37b4205b122: [test-suite] Fix custom section test on MachO Platforms.

Revision Contents

Path

Size

SingleSource/

Regression/

C++/

custom_section_members.cpp

9 lines

Diff 544889

SingleSource/Regression/C++/custom_section_members.cpp

	// Test that we can compile a simple class with members in a custom section.			// Test that we can compile a simple class with members in a custom section.
				#if defined(__APPLE__)
				#define SECTNAME "__TEXT,__section"
				#else
				#define SECTNAME "section"
				#endif

	struct A {			struct A {
	static int foo() __attribute__((section("section")));			static int foo() __attribute__((section(SECTNAME)));
	static void bar() __attribute__((section("section")));			static void bar() __attribute__((section(SECTNAME)));
	};			};

	int A::foo() { return 0; }			int A::foo() { return 0; }
	void A::bar() {}			void A::bar() {}

	int main() {			int main() {
	A::bar();			A::bar();
	return A::foo();			return A::foo();
	}			}