This is an archive of the discontinued LLVM Phabricator instance.

[Fuzzer] Update of SetThreadName for Windows
AbandonedPublic

Authored by devnexen on Jul 27 2023, 4:51 AM.

Details

Reviewers
vitalybuka
Summary

After trying out, it is safe to assume it goes further than a buffer of 16, also now needs to account the terminator.

Diff Detail

Event Timeline

devnexen created this revision.Jul 27 2023, 4:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2023, 4:51 AM
Herald added a subscriber: Enna1. · View Herald Transcript
devnexen requested review of this revision.Jul 27 2023, 4:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2023, 4:51 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
devnexen updated this revision to Diff 544713.Jul 27 2023, 4:53 AM
devnexen updated this revision to Diff 544715.Jul 27 2023, 4:59 AM
devnexen updated this revision to Diff 544716.
vitalybuka requested changes to this revision.Jul 27 2023, 9:10 AM

Please abandon this one, let's try https://reviews.llvm.org/D156317 again

This revision now requires changes to proceed.Jul 27 2023, 9:10 AM
devnexen updated this revision to Diff 544907.Jul 27 2023, 1:31 PM
  • advices from vitalybuka.

AH did not notice your comment do you still want me to move back to the other diff ?

AH did not notice your comment do you still want me to move back to the other diff ?

That's how we usually do: revert and reopen

compiler-rt/lib/fuzzer/FuzzerUtilWindows.cpp
242

Looks like you also didn't compile on windows?

name.data, name.size -> name.data(), name.size()

Make sure that uploaded patch is on top of origin/main, pre-merge checks has Windows

242

Looks like you also didn't compile on windows?

That's fine, just make "pre-merge checks" happy

vitalybuka resigned from this revision.Aug 10 2023, 7:03 PM

I guess we don't need this one

devnexen abandoned this revision.Aug 12 2023, 5:28 AM