This is an archive of the discontinued LLVM Phabricator instance.

[libc] Fix GPU tests failing after recent changes
ClosedPublic

Authored by jhuber6 on Jul 26 2023, 6:39 AM.

Details

Summary

Summray:
We landed some extra math support, which is apparently broken on the
max / min functions. the mod functions cannot be tested as they use
std::limits which don't exist in a freestanding environment. Also the
blockstore test seems to be broken. We will need to fix these in the
future but for now we need something in a workable state.

Diff Detail

Event Timeline

jhuber6 created this revision.Jul 26 2023, 6:39 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 26 2023, 6:39 AM
jhuber6 requested review of this revision.Jul 26 2023, 6:39 AM
jplehr accepted this revision.Jul 26 2023, 7:03 AM

LGTM

This revision is now accepted and ready to land.Jul 26 2023, 7:03 AM
This revision was automatically updated to reflect the committed changes.