This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Fix release notes about ASan
ClosedPublic

Authored by AdvenamTacet on Jul 24 2023, 12:20 PM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rG3326feb39729: [NFC] Fix release notes about ASan
Summary

Existing notes were not fully correct and were missing a detail:

  • std::vector was annotated long time ago,
  • std::deque annotations are new,
  • now container annotations were extended to all allocators (support in ASan API exists since LLVM16).

Diff Detail

Event Timeline

AdvenamTacet created this revision.Jul 24 2023, 12:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2023, 12:20 PM
AdvenamTacet requested review of this revision.Jul 24 2023, 12:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2023, 12:20 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision.Jul 24 2023, 12:55 PM

LGTM % comment.

libcxx/docs/ReleaseNotes/17.rst
110–113

I wouldn't go into too much detail here. We already added information about the annotations below. I think a design doc would be nice, but that will probably take too long for it to get into this release.

This revision is now accepted and ready to land.Jul 24 2023, 12:55 PM
AdvenamTacet retitled this revision from [NFC] Extend (and fix) release notes about ASan to [NFC] Fix release notes about ASan.Jul 24 2023, 3:34 PM
AdvenamTacet edited the summary of this revision. (Show Details)

Including suggestions.

AdvenamTacet marked an inline comment as done.

I changed order to avoid suggesting that std::deque has annotations not for all allocators.

libcxx/docs/ReleaseNotes/17.rst
110–113

I included the change, but we can consider informing wider userbase that alignment requirement is no longer existing as it's the very one thing everyone knows about ASan.

This revision was landed with ongoing or failed builds.Jul 24 2023, 7:50 PM
This revision was automatically updated to reflect the committed changes.