This is an archive of the discontinued LLVM Phabricator instance.

Set default C++ level for PlayStation(r) to C++17.
AcceptedPublic

Authored by Sunil_Srivastava on Jul 21 2023, 2:36 PM.

Details

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2023, 2:36 PM
Sunil_Srivastava requested review of this revision.Jul 21 2023, 2:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2023, 2:36 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Sunil_Srivastava retitled this revision from Set default C++ level for Playstation to C++17. to Set default C++ level for Playstation(r) to C++17..Jul 21 2023, 2:49 PM

The value of a separate test for PS4/PS5 is questionable, now that it's the same as the general Clang default.
Probably better to delete lang-std-sie.cpp and remove the UNSUPPORTED from lang-std.cpp ?

Sunil_Srivastava retitled this revision from Set default C++ level for Playstation(r) to C++17. to Set default C++ level for PlayStation(r) to C++17..Jul 21 2023, 2:49 PM

(Also remove the now-incorrect comment from lang-std.cpp)

Deleted Sie specific test, now that the behavior is same as the default.

probinson accepted this revision.Jul 21 2023, 3:29 PM

Huh. It looks like someone else removed that stuff from lang-std.cpp recently. I'd have thought that would cause a failure on our bot, but whatever.
LGTM.

This revision is now accepted and ready to land.Jul 21 2023, 3:29 PM