User Details
User Details
- User Since
- May 9 2013, 11:11 AM (483 w, 2 d)
Oct 17 2019
Oct 17 2019
Request commit access for jmagee.
Mar 17 2015
Mar 17 2015
Feb 4 2015
Feb 4 2015
Catch more cases when diagnosing integer-constant-expression overflows.
Feb 3 2015
Feb 3 2015
jmagee updated the diff for D1238: Catch more cases when diagnosing integer-constant-expression overflows..
Thanks for the review, Richard. Here is a new patch that hopefully addresses your feedback.
I'm honestly a bit uncertain about how I'm handling the LHS of an assignment. Evaluating it as an LValue makes sense because, as you pointed out, there may be overflow there. However I don't see anything particularly useful that can be done with the result, particularly since I go on to set LHSOK to false. That said, the code looks awkward enough that it feels like I could be overlooking something here.
jmagee added inline comments to D1238: Catch more cases when diagnosing integer-constant-expression overflows..
Jan 29 2015
Jan 29 2015
jmagee updated the diff for D1238: Catch more cases when diagnosing integer-constant-expression overflows..
Refreshing a _very_ old patch.