Page MenuHomePhabricator

jmagee (Josh Magee)
User

Projects

User does not belong to any projects.

User Details

User Since
May 9 2013, 11:11 AM (332 w, 1 d)

Recent Activity

Mar 17 2015

jmagee committed rL232580: Add testcases for BEXTR..
Add testcases for BEXTR.
Mar 17 2015, 6:36 PM

Feb 4 2015

jmagee committed rL228202: Catch more cases when diagnosing integer-constant-expression overflows..
Catch more cases when diagnosing integer-constant-expression overflows.
Feb 4 2015, 1:52 PM
jmagee closed D1238: Catch more cases when diagnosing integer-constant-expression overflows. by committing rL228202: Catch more cases when diagnosing integer-constant-expression overflows..
Feb 4 2015, 1:52 PM

Feb 3 2015

jmagee updated the diff for D1238: Catch more cases when diagnosing integer-constant-expression overflows..

Thanks for the review, Richard. Here is a new patch that hopefully addresses your feedback.
I'm honestly a bit uncertain about how I'm handling the LHS of an assignment. Evaluating it as an LValue makes sense because, as you pointed out, there may be overflow there. However I don't see anything particularly useful that can be done with the result, particularly since I go on to set LHSOK to false. That said, the code looks awkward enough that it feels like I could be overlooking something here.

Feb 3 2015, 4:01 PM
jmagee added inline comments to D1238: Catch more cases when diagnosing integer-constant-expression overflows..
Feb 3 2015, 3:55 PM

Jan 29 2015

jmagee updated the diff for D1238: Catch more cases when diagnosing integer-constant-expression overflows..

Refreshing a _very_ old patch.

Jan 29 2015, 7:22 PM