This is an archive of the discontinued LLVM Phabricator instance.

Differential D155880

[libc++] Remove variables that are not necessary anymore inside header_information.py
ClosedPublic

Authored by ldionne on Jul 20 2023, 1:00 PM.

Details

Reviewers
iana
Group Reviewers
Restricted Project
Commits
rG5e673481584c: [libc++] Remove variables that are not necessary anymore inside…
Summary

Those are not relevant anymore since we don't have tests for private
headers anymore.

Diff Detail

Unit TestsFailed

TimeTest
7,910 mslibcxx CI - Modular build > llvm-libc++-shared-cfg-in.libcxx/containers/associative/map::find.modules.compile.pass.mm
10,130 mslibcxx CI - Modular build > llvm-libc++-shared-cfg-in.libcxx/containers/sequences/vector::erase.modules.compile.pass.mm
51,990 mslibcxx CI - Modular build > llvm-libc++-shared-cfg-in.libcxx/depr/depr_default_allocator/allocator_members::allocate.cxx2a.pass.cpp
28,440 mslibcxx CI - Modular build > llvm-libc++-shared-cfg-in.libcxx/diagnostics::format.nodiscard_extensions.compile.pass.cpp
33,540 mslibcxx CI - Modular build > llvm-libc++-shared-cfg-in.libcxx/diagnostics::nodiscard_extensions.verify.cpp
View Full Test Results (48 Failed)

Event Timeline

ldionne created this revision.Jul 20 2023, 1:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2023, 1:00 PM
Herald added a subscriber: arichardson. · View Herald Transcript
ldionne requested review of this revision.Jul 20 2023, 1:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2023, 1:00 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
ldionne added a reviewer: iana.Jul 20 2023, 1:00 PM
iana accepted this revision.Jul 20 2023, 1:01 PM
Harbormaster completed remote builds in B247004: Diff 542645.Jul 20 2023, 1:38 PM
ldionne updated this revision to Diff 543017.Jul 21 2023, 11:49 AM

Poke CI

ldionne updated this revision to Diff 547837.Aug 7 2023, 10:12 AM

Rebase.

ldionne accepted this revision as: Restricted Project.Aug 7 2023, 12:21 PM
This revision is now accepted and ready to land.Aug 7 2023, 12:21 PM
Harbormaster completed remote builds in B250824: Diff 547837.Aug 7 2023, 1:48 PM
ldionne added a comment.Aug 8 2023, 5:46 AM

AIX failure is a fluke, shipping.

This revision was landed with ongoing or failed builds.Aug 8 2023, 5:47 AM
Closed by commit rG5e673481584c: [libc++] Remove variables that are not necessary anymore inside… (authored by ldionne). · Explain Why
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rG5e673481584c: [libc++] Remove variables that are not necessary anymore inside….

Revision Contents

PathSize
libcxx/
utils/
libcxx/
test/
30 lines

Diff 542645

libcxx/utils/libcxx/test/header_information.py

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Lineslit_header_restrictions = {
"stop_token": "// UNSUPPORTED: no-threads, c++03, c++11, c++14, c++17", "stop_token": "// UNSUPPORTED: no-threads, c++03, c++11, c++14, c++17",
"streambuf": "// UNSUPPORTED: no-localization", "streambuf": "// UNSUPPORTED: no-localization",
"strstream": "// UNSUPPORTED: no-localization", "strstream": "// UNSUPPORTED: no-localization",
"thread": "// UNSUPPORTED: no-threads, c++03", "thread": "// UNSUPPORTED: no-threads, c++03",
"wchar.h": "// UNSUPPORTED: no-wide-characters", "wchar.h": "// UNSUPPORTED: no-wide-characters",
"wctype.h": "// UNSUPPORTED: no-wide-characters", "wctype.h": "// UNSUPPORTED: no-wide-characters",
} }
private_headers_still_public_in_modules = [
"__assert",
"__config",
"__config_site.in",
"__hash_table",
"__threading_support",
"__tree",
"__undef_macros",
"__verbose_abort",
]
# Headers that can't be included on their own. Most of these are conceptually
# part of another header that were split out just for organization, but aren't
# meant to be included by anything else.
non_standalone_headers = frozenset((
# Alternate implementations for __algorithm/pstl_backends/cpu_backends/backend.h
"__algorithm/pstl_backends/cpu_backends/serial.h",
"__algorithm/pstl_backends/cpu_backends/thread.h",
# Alternate implementations for locale.
"__locale_dir/locale_base_api/bsd_locale_defaults.h",
"__locale_dir/locale_base_api/bsd_locale_fallbacks.h",
))
# This table was produced manually, by grepping the TeX source of the Standard's # This table was produced manually, by grepping the TeX source of the Standard's
# library clauses for the string "#include". Each header's synopsis contains # library clauses for the string "#include". Each header's synopsis contains
# explicit "#include" directives for its mandatory inclusions. # explicit "#include" directives for its mandatory inclusions.
# For example, [algorithm.syn] contains "#include <initializer_list>". # For example, [algorithm.syn] contains "#include <initializer_list>".
mandatory_inclusions = { mandatory_inclusions = {
"algorithm": ["initializer_list"], "algorithm": ["initializer_list"],
"array": ["compare", "initializer_list"], "array": ["compare", "initializer_list"],
"bitset": ["iosfwd", "string"], "bitset": ["iosfwd", "string"],
▲ Show 20 Lines • Show All 49 Lines • ▼ Show 20 Lines
toplevel_headers = sorted( toplevel_headers = sorted(
p.relative_to(include).as_posix() for p in include.glob("[a-z]*") if is_header(p) p.relative_to(include).as_posix() for p in include.glob("[a-z]*") if is_header(p)
) )
experimental_headers = sorted( experimental_headers = sorted(
p.relative_to(include).as_posix() for p in include.glob("experimental/[a-z]*") if is_header(p) p.relative_to(include).as_posix() for p in include.glob("experimental/[a-z]*") if is_header(p)
) )
public_headers = toplevel_headers + experimental_headers public_headers = toplevel_headers + experimental_headers
private_headers = sorted(
p.relative_to(include).as_posix() for p in include.rglob("*") if is_header(p)
and str(p.relative_to(include)).startswith("__")
and not p.name.startswith("pstl")
and str(p.relative_to(include)) not in non_standalone_headers
)