This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Fix tests for the runtime assertions in <barrier>
ClosedPublic

Authored by diamante0018 on Jul 19 2023, 2:47 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGd16115ddfcc4: [libc++] Fix tests for the runtime assertions in <barrier>
Summary

As @ldionne pointed out to me in a newer revision, there is a //REQUIRE comment in both files edited by this patch that prevents the test to run on some platforms where it should actually run.

Diff Detail

Event Timeline

diamante0018 created this revision.Jul 19 2023, 2:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2023, 2:47 PM
diamante0018 requested review of this revision.Jul 19 2023, 2:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2023, 2:47 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
diamante0018 edited the summary of this revision. (Show Details)Jul 19 2023, 2:48 PM
diamante0018 added a reviewer: ldionne.
diamante0018 added a subscriber: ldionne.
ldionne accepted this revision.Jul 19 2023, 3:24 PM

LGTM. Please rebase on top of main to ensure you get a green CI run. In the current state of things you'll see some red, so I'll cancel your CI job.

This revision is now accepted and ready to land.Jul 19 2023, 3:24 PM

Since the CI turned green here are my details.

Edoardo Sanguineti<edoardo.sanguineti222@gmail.com>

Thanks