As @ldionne pointed out to me in a newer revision, there is a //REQUIRE comment in both files edited by this patch that prevents the test to run on some platforms where it should actually run.
Details
Details
- Reviewers
ldionne - Group Reviewers
Restricted Project - Commits
- rGd16115ddfcc4: [libc++] Fix tests for the runtime assertions in <barrier>
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM. Please rebase on top of main to ensure you get a green CI run. In the current state of things you'll see some red, so I'll cancel your CI job.
Comment Actions
Since the CI turned green here are my details.
Edoardo Sanguineti<edoardo.sanguineti222@gmail.com>
Thanks