This is an archive of the discontinued LLVM Phabricator instance.

Differential D15574

Remove datalayout and target triple from test cases related to LiveDebugValues pass.
AbandonedPublic

Authored by tvvikram on Dec 16 2015, 9:10 AM.

Details

Reviewers
aprantl
Summary

Buildbots failed with architectures other than x86 for a new test case added in commit rL255759.
The test case contained x86 specific target triple - 'x86_64-unknown-linux-gnu' as seen from http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/8377/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3Alive-debug-values.ll.

I have removed the datalayout and target triple lines from the test case (including related test cases). This made the test cases "generic" i.e. moved the test cases into "Generic" folder.

Diff Detail

Event Timeline

tvvikram updated this revision to Diff 43015.Dec 16 2015, 9:10 AM
tvvikram retitled this revision from to Remove datalayout and target triple from test cases related to LiveDebugValues pass..
tvvikram updated this object.
tvvikram added a reviewer: aprantl.
tvvikram added a subscriber: loladiro.
Herald added a subscriber: aemerson. · View Herald TranscriptDec 16 2015, 9:10 AM
kparzysz added a subscriber: kparzysz.Dec 16 2015, 10:38 AM

The testcase is still x86-specific, since it checks for x86 register names. The Hexagon build bot only builds the Hexagon target.

tobiasvk added a subscriber: tobiasvk.Dec 16 2015, 10:55 AM

I just did

$ bin/llc -march=hexagon -filetype=asm ../llvm/test/DebugInfo/live-debug-values.ll -o - | bin/FileCheck ../llvm/test/DebugInfo/live-debug-values.ll
../llvm/test/DebugInfo/live-debug-values.ll:32:10: error: expected string not found in input
; CHECK: .LBB0_5:
         ^
<stdin>:1:2: note: scanning from here
 .text
 ^
<stdin>:70:1: note: possible intended match here
.LBB0_2: // %if.else.5
^

so it seems your test case is still to x86-specific.

tvvikram updated this revision to Diff 43039.Dec 16 2015, 11:05 AM

Retained the test cases in X86 folder as they are not generic.

tobiasvk added a comment.Dec 16 2015, 11:51 AM

LGTM conceptually. The patch doesn't apply to the current repo though (I guess it's a diff against what you had locally).

aprantl edited edge metadata.Dec 16 2015, 12:53 PM

The right fix for this is to move the test to an X86 subdirectory and add a lit.local.cfg file like the one in test/DebugInfo/X86/.

MIR/X86/live-debug-values-3preds.mir
0

Since you are actually checking for x86 register names I don't see the point in removing the target triple from the test. I would just leave it in.

tvvikram added inline comments.Dec 16 2015, 6:04 PM
MIR/X86/live-debug-values-3preds.mir
0

I checked a few existing test cases in DebugInfo/X86 and they didn't contain the triple. So I had removed it.

tvvikram added a comment.Dec 16 2015, 6:09 PM

Fixed by chapuni in rL255834. Will abandon this patch.

tvvikram abandoned this revision.Dec 16 2015, 6:13 PM

Revision Contents

Diff 43015

Generic/live-debug-values.ll

Show All 29 Lines
; DBG_VALUE for variable "n" is extended into BB#5 from its predecessors BB#3 ; DBG_VALUE for variable "n" is extended into BB#5 from its predecessors BB#3
; and BB#4. ; and BB#4.
; CHECK: .LBB0_5: ; CHECK: .LBB0_5:
; CHECK-NEXT: #DEBUG_VALUE: main:argv <- %RSI ; CHECK-NEXT: #DEBUG_VALUE: main:argv <- %RSI
; CHECK-NEXT: #DEBUG_VALUE: main:n <- %EBX ; CHECK-NEXT: #DEBUG_VALUE: main:n <- %EBX
; ModuleID = 'LiveDebugValues.c' ; ModuleID = 'LiveDebugValues.c'
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
@m = common global i32 0, align 4 @m = common global i32 0, align 4
@.str = private unnamed_addr constant [13 x i8] c"m(main): %d\0A\00", align 1 @.str = private unnamed_addr constant [13 x i8] c"m(main): %d\0A\00", align 1
; Function Attrs: nounwind uwtable ; Function Attrs: nounwind uwtable
define i32 @main(i32 %argc, i8** nocapture readonly %argv) #0 !dbg !4 { define i32 @main(i32 %argc, i8** nocapture readonly %argv) #0 !dbg !4 {
entry: entry:
tail call void @llvm.dbg.value(metadata i32 %argc, i64 0, metadata !12, metadata !20), !dbg !21 tail call void @llvm.dbg.value(metadata i32 %argc, i64 0, metadata !12, metadata !20), !dbg !21
▲ Show 20 Lines • Show All 106 Lines • Show Last 20 Lines

MIR/Generic/lit.local.cfg

if not 'X86' in config.root.targets: if not config.root.targets:
config.unsupported = True config.unsupported = True

MIR/Generic/live-debug-values-3preds.mir

Show All 28 Lines
# CHECK: bb.9.for.end: # CHECK: bb.9.for.end:
# CHECK: DBG_VALUE debug-use %edx, debug-use _, !11, !17, debug-location !21 # CHECK: DBG_VALUE debug-use %edx, debug-use _, !11, !17, debug-location !21
# CHECK-NEXT: DBG_VALUE debug-use %esi, debug-use _, !10, !17, debug-location !19 # CHECK-NEXT: DBG_VALUE debug-use %esi, debug-use _, !10, !17, debug-location !19
# CHECK-NEXT: DBG_VALUE debug-use %edi, debug-use _, !9, !17, debug-location !18 # CHECK-NEXT: DBG_VALUE debug-use %edi, debug-use _, !9, !17, debug-location !18
--- | --- |
; ModuleID = 'live-debug-values-3preds.ll' ; ModuleID = 'live-debug-values-3preds.ll'
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
; Function Attrs: norecurse nounwind readnone uwtable ; Function Attrs: norecurse nounwind readnone uwtable
define i32 @add(i32 %x, i32 %y, i32 %z, i32 %a) #0 !dbg !4 { define i32 @add(i32 %x, i32 %y, i32 %z, i32 %a) #0 !dbg !4 {
entry: entry:
tail call void @llvm.dbg.value(metadata i32 %x, i64 0, metadata !9, metadata !17), !dbg !18 tail call void @llvm.dbg.value(metadata i32 %x, i64 0, metadata !9, metadata !17), !dbg !18
tail call void @llvm.dbg.value(metadata i32 %y, i64 0, metadata !10, metadata !17), !dbg !19 tail call void @llvm.dbg.value(metadata i32 %y, i64 0, metadata !10, metadata !17), !dbg !19
tail call void @llvm.dbg.value(metadata i32 %z, i64 0, metadata !11, metadata !17), !dbg !21 tail call void @llvm.dbg.value(metadata i32 %z, i64 0, metadata !11, metadata !17), !dbg !21
tail call void @llvm.dbg.value(metadata i32 %a, i64 0, metadata !12, metadata !17), !dbg !23 tail call void @llvm.dbg.value(metadata i32 %a, i64 0, metadata !12, metadata !17), !dbg !23
▲ Show 20 Lines • Show All 253 Lines • Show Last 20 Lines

MIR/Generic/live-debug-values.mir

Show All 33 Lines
# and BB#4. # and BB#4.
# CHECK: bb.5.if.end.7: # CHECK: bb.5.if.end.7:
# CHECK: DBG_VALUE debug-use %rsi, debug-use _, !13, !20, debug-location !22 # CHECK: DBG_VALUE debug-use %rsi, debug-use _, !13, !20, debug-location !22
# CHECK-NEXT: DBG_VALUE debug-use %ebx, debug-use _, !14, !20, debug-location !33 # CHECK-NEXT: DBG_VALUE debug-use %ebx, debug-use _, !14, !20, debug-location !33
--- | --- |
; ModuleID = 'live-debug-values.ll' ; ModuleID = 'live-debug-values.ll'
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
@m = common global i32 0, align 4 @m = common global i32 0, align 4
@.str = private unnamed_addr constant [13 x i8] c"m(main): %d\0A\00", align 1 @.str = private unnamed_addr constant [13 x i8] c"m(main): %d\0A\00", align 1
; Function Attrs: nounwind uwtable ; Function Attrs: nounwind uwtable
define i32 @main(i32 %argc, i8** nocapture readonly %argv) #0 !dbg !4 { define i32 @main(i32 %argc, i8** nocapture readonly %argv) #0 !dbg !4 {
entry: entry:
tail call void @llvm.dbg.value(metadata i32 %argc, i64 0, metadata !12, metadata !20), !dbg !21 tail call void @llvm.dbg.value(metadata i32 %argc, i64 0, metadata !12, metadata !20), !dbg !21
▲ Show 20 Lines • Show All 209 Lines • Show Last 20 Lines

MIR/X86/lit.local.cfg

if not 'X86' in config.root.targets:
config.unsupported = True

MIR/X86/live-debug-values-3preds.mir

# RUN: llc -run-pass=livedebugvalues -march=x86-64 -o /dev/null %s | FileCheck %s
# Test the extension of debug ranges from 3 predecessors.
# Generated from the source file LiveDebugValues-3preds.c:
# #include <stdio.h>
# int add(int x, int y, int z, int a) {
# int i;
# for (i = 0; i < x * y; i++) {
# if (i < x) {
# a = a * x;
# break;
# }
# if (i < y) {
# a = a * y;
# break;
# }
# if (i < z) {
# a = a * z;
# break;
# }
# }
# return a;
# }
# with clang -g -O1 -c -emit-llvm LiveDebugValues-3preds.c -S -o live-debug-values-3preds.ll
# then llc -stop-after stackmap-liveness live-debug-values-3preds.ll -o /dev/null > live-debug-values-3preds.mir
# DBG_VALUE for variables "x", "y" and "z" are extended into BB#9 from its
# predecessors BB#0, BB#2 and BB#8.
# CHECK: bb.9.for.end:
# CHECK: DBG_VALUE debug-use %edx, debug-use _, !11, !17, debug-location !21
# CHECK-NEXT: DBG_VALUE debug-use %esi, debug-use _, !10, !17, debug-location !19
# CHECK-NEXT: DBG_VALUE debug-use %edi, debug-use _, !9, !17, debug-location !18
--- |
; ModuleID = 'live-debug-values-3preds.ll'
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
; Function Attrs: norecurse nounwind readnone uwtable
define i32 @add(i32 %x, i32 %y, i32 %z, i32 %a) #0 !dbg !4 {
entry:
tail call void @llvm.dbg.value(metadata i32 %x, i64 0, metadata !9, metadata !17), !dbg !18
tail call void @llvm.dbg.value(metadata i32 %y, i64 0, metadata !10, metadata !17), !dbg !19
tail call void @llvm.dbg.value(metadata i32 %z, i64 0, metadata !11, metadata !17), !dbg !21
tail call void @llvm.dbg.value(metadata i32 %a, i64 0, metadata !12, metadata !17), !dbg !23
tail call void @llvm.dbg.value(metadata i32 0, i64 0, metadata !13, metadata !17), !dbg !25
%mul = mul nsw i32 %y, %x, !dbg !26
%cmp.24 = icmp sgt i32 %mul, 0, !dbg !30
br i1 %cmp.24, label %for.body.preheader, label %for.end, !dbg !31
for.body.preheader: ; preds = %entry
br label %for.body, !dbg !32
for.cond: ; preds = %if.end.6
%cmp = icmp slt i32 %inc, %mul, !dbg !30
br i1 %cmp, label %for.body, label %for.end, !dbg !31
for.body: ; preds = %for.cond, %for.body.preheader
%i.025 = phi i32 [ %inc, %for.cond ], [ 0, %for.body.preheader ]
%0 = icmp sgt i32 %x, 0
br i1 %0, label %if.then, label %if.end, !dbg !35
if.then: ; preds = %for.body
%mul2 = mul nsw i32 %a, %x, !dbg !36
tail call void @llvm.dbg.value(metadata i32 %mul2, i64 0, metadata !12, metadata !17), !dbg !23
br label %for.end, !dbg !38
if.end: ; preds = %for.body
%1 = icmp sgt i32 %y, 0
br i1 %1, label %if.then.4, label %if.end.6, !dbg !39
if.then.4: ; preds = %if.end
%mul5 = mul nsw i32 %a, %y, !dbg !40
tail call void @llvm.dbg.value(metadata i32 %mul5, i64 0, metadata !12, metadata !17), !dbg !23
br label %for.end, !dbg !43
if.end.6: ; preds = %if.end
%2 = icmp sgt i32 %z, 0
%inc = add nuw nsw i32 %i.025, 1, !dbg !44
tail call void @llvm.dbg.value(metadata i32 %inc, i64 0, metadata !13, metadata !17), !dbg !25
br i1 %2, label %if.then.8, label %for.cond, !dbg !45
if.then.8: ; preds = %if.end.6
%mul9 = mul nsw i32 %a, %z, !dbg !46
tail call void @llvm.dbg.value(metadata i32 %mul9, i64 0, metadata !12, metadata !17), !dbg !23
br label %for.end, !dbg !49
for.end: ; preds = %for.cond, %if.then.8, %if.then.4, %if.then, %entry
%a.addr.0 = phi i32 [ %mul2, %if.then ], [ %mul5, %if.then.4 ], [ %mul9, %if.then.8 ], [ %a, %entry ], [ %a, %for.cond ]
ret i32 %a.addr.0, !dbg !50
}
; Function Attrs: nounwind readnone
declare void @llvm.dbg.value(metadata, i64, metadata, metadata) #1
attributes #0 = { norecurse nounwind readnone uwtable }
attributes #1 = { nounwind readnone }
!llvm.dbg.cu = !{!0}
!llvm.module.flags = !{!14, !15}
!llvm.ident = !{!16}
!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang version 3.8.0 (trunk 253049) ", isOptimized: true, runtimeVersion: 0, emissionKind: 1, enums: !2, subprograms: !3)
!1 = !DIFile(filename: "LiveDebugValues-3preds.c", directory: "/home/vt/julia/test/tvvikram")
!2 = !{}
!3 = !{!4}
!4 = distinct !DISubprogram(name: "add", scope: !1, file: !1, line: 1, type: !5, isLocal: false, isDefinition: true, scopeLine: 1, flags: DIFlagPrototyped, isOptimized: true, variables: !8)
!5 = !DISubroutineType(types: !6)
!6 = !{!7, !7, !7, !7, !7}
!7 = !DIBasicType(name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
!8 = !{!9, !10, !11, !12, !13}
!9 = !DILocalVariable(name: "x", arg: 1, scope: !4, file: !1, line: 1, type: !7)
!10 = !DILocalVariable(name: "y", arg: 2, scope: !4, file: !1, line: 1, type: !7)
!11 = !DILocalVariable(name: "z", arg: 3, scope: !4, file: !1, line: 1, type: !7)
!12 = !DILocalVariable(name: "a", arg: 4, scope: !4, file: !1, line: 1, type: !7)
!13 = !DILocalVariable(name: "i", scope: !4, file: !1, line: 2, type: !7)
!14 = !{i32 2, !"Dwarf Version", i32 4}
!15 = !{i32 2, !"Debug Info Version", i32 3}
!16 = !{!"clang version 3.8.0 (trunk 253049) "}
!17 = !DIExpression()
!18 = !DILocation(line: 1, column: 13, scope: !4)
!19 = !DILocation(line: 1, column: 20, scope: !20)
!20 = !DILexicalBlockFile(scope: !4, file: !1, discriminator: 1)
!21 = !DILocation(line: 1, column: 27, scope: !22)
!22 = !DILexicalBlockFile(scope: !4, file: !1, discriminator: 2)
!23 = !DILocation(line: 1, column: 34, scope: !24)
!24 = !DILexicalBlockFile(scope: !4, file: !1, discriminator: 3)
!25 = !DILocation(line: 2, column: 7, scope: !20)
!26 = !DILocation(line: 3, column: 21, scope: !27)
!27 = !DILexicalBlockFile(scope: !28, file: !1, discriminator: 1)
!28 = distinct !DILexicalBlock(scope: !29, file: !1, line: 3, column: 3)
!29 = distinct !DILexicalBlock(scope: !4, file: !1, line: 3, column: 3)
!30 = !DILocation(line: 3, column: 17, scope: !27)
!31 = !DILocation(line: 3, column: 3, scope: !27)
!32 = !DILocation(line: 4, column: 11, scope: !33)
!33 = distinct !DILexicalBlock(scope: !34, file: !1, line: 4, column: 9)
!34 = distinct !DILexicalBlock(scope: !28, file: !1, line: 3, column: 31)
!35 = !DILocation(line: 4, column: 9, scope: !34)
!36 = !DILocation(line: 5, column: 13, scope: !37)
!37 = distinct !DILexicalBlock(scope: !33, file: !1, line: 4, column: 16)
!38 = !DILocation(line: 6, column: 7, scope: !37)
!39 = !DILocation(line: 8, column: 9, scope: !34)
!40 = !DILocation(line: 9, column: 13, scope: !41)
!41 = distinct !DILexicalBlock(scope: !42, file: !1, line: 8, column: 16)
!42 = distinct !DILexicalBlock(scope: !34, file: !1, line: 8, column: 9)
!43 = !DILocation(line: 10, column: 7, scope: !41)
!44 = !DILocation(line: 3, column: 27, scope: !28)
!45 = !DILocation(line: 12, column: 9, scope: !34)
!46 = !DILocation(line: 13, column: 13, scope: !47)
!47 = distinct !DILexicalBlock(scope: !48, file: !1, line: 12, column: 16)
!48 = distinct !DILexicalBlock(scope: !34, file: !1, line: 12, column: 9)
!49 = !DILocation(line: 14, column: 7, scope: !47)
!50 = !DILocation(line: 17, column: 3, scope: !4)
...
---
name: add
alignment: 4
exposesReturnsTwice: false
hasInlineAsm: false
isSSA: false
tracksRegLiveness: true
tracksSubRegLiveness: false
liveins:
- { reg: '%edi' }
- { reg: '%esi' }
- { reg: '%edx' }
- { reg: '%ecx' }
frameInfo:
isFrameAddressTaken: false
isReturnAddressTaken: false
hasStackMap: false
hasPatchPoint: false
stackSize: 0
offsetAdjustment: 0
maxAlignment: 0
adjustsStack: false
hasCalls: false
maxCallFrameSize: 0
hasOpaqueSPAdjustment: false
hasVAStart: false
hasMustTailInVarArgFunc: false
body: |
bb.0.entry:
successors: %bb.1.for.body.preheader(20), %bb.9.for.end(12)
liveins: %ecx, %edi, %edx, %esi
DBG_VALUE debug-use %edi, debug-use _, !9, !17, debug-location !18
DBG_VALUE debug-use %esi, debug-use _, !10, !17, debug-location !19
DBG_VALUE debug-use %edx, debug-use _, !11, !17, debug-location !21
DBG_VALUE debug-use %ecx, debug-use _, !12, !17, debug-location !23
DBG_VALUE 0, 0, !13, !17, debug-location !25
%r8d = MOV32rr %esi, debug-location !26
%r8d = IMUL32rr killed %r8d, %edi, implicit-def dead %eflags, debug-location !26
TEST32rr %r8d, %r8d, implicit-def %eflags, debug-location !31
JLE_1 %bb.9.for.end, implicit %eflags
bb.1.for.body.preheader:
successors: %bb.3.for.body(0)
liveins: %ecx, %edi, %edx, %esi, %r8d
DBG_VALUE debug-use %edi, debug-use _, !9, !17, debug-location !18
DBG_VALUE debug-use %esi, debug-use _, !10, !17, debug-location !19
DBG_VALUE debug-use %edx, debug-use _, !11, !17, debug-location !21
DBG_VALUE debug-use %ecx, debug-use _, !12, !17, debug-location !23
DBG_VALUE 0, 0, !13, !17, debug-location !25
%eax = XOR32rr undef %eax, undef %eax, implicit-def dead %eflags
bb.3.for.body (align 4):
successors: %bb.4.if.then(4), %bb.5.if.end(124)
liveins: %eax, %ecx, %edi, %edx, %esi, %r8d
DBG_VALUE debug-use %edi, debug-use _, !9, !17, debug-location !18
DBG_VALUE debug-use %esi, debug-use _, !10, !17, debug-location !19
DBG_VALUE debug-use %edx, debug-use _, !11, !17, debug-location !21
DBG_VALUE debug-use %ecx, debug-use _, !12, !17, debug-location !23
DBG_VALUE 0, 0, !13, !17, debug-location !25
TEST32rr %edi, %edi, implicit-def %eflags, debug-location !35
JG_1 %bb.4.if.then, implicit %eflags
bb.5.if.end:
successors: %bb.6.if.then.4(4), %bb.7.if.end.6(124)
liveins: %eax, %ecx, %edi, %edx, %esi, %r8d
DBG_VALUE debug-use %edi, debug-use _, !9, !17, debug-location !18
DBG_VALUE debug-use %esi, debug-use _, !10, !17, debug-location !19
DBG_VALUE debug-use %edx, debug-use _, !11, !17, debug-location !21
DBG_VALUE debug-use %ecx, debug-use _, !12, !17, debug-location !23
DBG_VALUE 0, 0, !13, !17, debug-location !25
TEST32rr %esi, %esi, implicit-def %eflags, debug-location !39
JG_1 %bb.6.if.then.4, implicit %eflags
bb.7.if.end.6:
successors: %bb.8.if.then.8(4), %bb.2.for.cond(124)
liveins: %eax, %ecx, %edi, %edx, %esi, %r8d
DBG_VALUE debug-use %edi, debug-use _, !9, !17, debug-location !18
DBG_VALUE debug-use %esi, debug-use _, !10, !17, debug-location !19
DBG_VALUE debug-use %edx, debug-use _, !11, !17, debug-location !21
DBG_VALUE debug-use %ecx, debug-use _, !12, !17, debug-location !23
DBG_VALUE 0, 0, !13, !17, debug-location !25
TEST32rr %edx, %edx, implicit-def %eflags, debug-location !45
JG_1 %bb.8.if.then.8, implicit %eflags
bb.2.for.cond:
successors: %bb.3.for.body(124), %bb.9.for.end(4)
liveins: %eax, %ecx, %edi, %edx, %esi, %r8d
DBG_VALUE debug-use %edi, debug-use _, !9, !17, debug-location !18
DBG_VALUE debug-use %esi, debug-use _, !10, !17, debug-location !19
DBG_VALUE debug-use %edx, debug-use _, !11, !17, debug-location !21
DBG_VALUE debug-use %ecx, debug-use _, !12, !17, debug-location !23
DBG_VALUE 0, 0, !13, !17, debug-location !25
%eax = INC32r killed %eax, implicit-def dead %eflags, debug-location !44
DBG_VALUE debug-use %eax, debug-use _, !13, !17, debug-location !25
CMP32rr %eax, %r8d, implicit-def %eflags, debug-location !31
JL_1 %bb.3.for.body, implicit %eflags
JMP_1 %bb.9.for.end
bb.4.if.then:
liveins: %ecx, %edi
DBG_VALUE debug-use %edi, debug-use _, !9, !17, debug-location !18
DBG_VALUE debug-use %ecx, debug-use _, !12, !17, debug-location !23
DBG_VALUE 0, 0, !13, !17, debug-location !25
%ecx = IMUL32rr killed %ecx, killed %edi, implicit-def dead %eflags, debug-location !36
DBG_VALUE 0, 0, !13, !17, debug-location !25
%eax = MOV32rr killed %ecx, debug-location !50
RETQ %eax, debug-location !50
bb.6.if.then.4:
liveins: %ecx, %esi
DBG_VALUE debug-use %esi, debug-use _, !10, !17, debug-location !19
DBG_VALUE debug-use %ecx, debug-use _, !12, !17, debug-location !23
DBG_VALUE 0, 0, !13, !17, debug-location !25
%ecx = IMUL32rr killed %ecx, killed %esi, implicit-def dead %eflags, debug-location !40
DBG_VALUE 0, 0, !13, !17, debug-location !25
%eax = MOV32rr killed %ecx, debug-location !50
RETQ %eax, debug-location !50
bb.8.if.then.8:
successors: %bb.9.for.end(0)
liveins: %ecx, %edx
DBG_VALUE debug-use %edx, debug-use _, !11, !17, debug-location !21
DBG_VALUE debug-use %ecx, debug-use _, !12, !17, debug-location !23
DBG_VALUE 0, 0, !13, !17, debug-location !25
%ecx = IMUL32rr killed %ecx, killed %edx, implicit-def dead %eflags, debug-location !46
bb.9.for.end:
liveins: %ecx
DBG_VALUE 0, 0, !13, !17, debug-location !25
%eax = MOV32rr killed %ecx, debug-location !50
RETQ %eax, debug-location !50
...

MIR/X86/live-debug-values.mir

# RUN: llc -run-pass=livedebugvalues -march=x86-64 -o /dev/null %s | FileCheck %s
# Test the extension of debug ranges from predecessors.
# Generated from the source file LiveDebugValues.c:
# #include <stdio.h>
# int m;
# extern int inc(int n);
# extern int change(int n);
# extern int modify(int n);
# int main(int argc, char **argv) {
# int n;
# if (argc != 2)
# n = 2;
# else
# n = atoi(argv[1]);
# n = change(n);
# if (n > 10) {
# m = modify(n);
# m = m + n; // var `m' doesn't has a dbg.value
# }
# else
# m = inc(n); // var `m' doesn't has a dbg.value
# printf("m(main): %d\n", m);
# return 0;
# }
# with clang -g -O3 -c -emit-llvm LiveDebugValues.c -S -o live-debug-values.ll
# then llc -stop-after stackmap-liveness live-debug-values.ll -o /dev/null > live-debug-values.mir
# This case will also produce multiple locations but only the debug range
# extension is tested here. This test case is tested with DWARF information under
# llvm/test/DebugInfo/live-debug-values.ll and present here for testing under
# MIR->MIR serialization.
# DBG_VALUE for variable "n" is extended into BB#5 from its predecessors BB#3
# and BB#4.
# CHECK: bb.5.if.end.7:
# CHECK: DBG_VALUE debug-use %rsi, debug-use _, !13, !20, debug-location !22
# CHECK-NEXT: DBG_VALUE debug-use %ebx, debug-use _, !14, !20, debug-location !33
--- |
; ModuleID = 'live-debug-values.ll'
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
@m = common global i32 0, align 4
@.str = private unnamed_addr constant [13 x i8] c"m(main): %d\0A\00", align 1
; Function Attrs: nounwind uwtable
define i32 @main(i32 %argc, i8** nocapture readonly %argv) #0 !dbg !4 {
entry:
tail call void @llvm.dbg.value(metadata i32 %argc, i64 0, metadata !12, metadata !20), !dbg !21
tail call void @llvm.dbg.value(metadata i8** %argv, i64 0, metadata !13, metadata !20), !dbg !22
%cmp = icmp eq i32 %argc, 2, !dbg !24
br i1 %cmp, label %if.else, label %if.end, !dbg !26
if.else: ; preds = %entry
%arrayidx = getelementptr inbounds i8*, i8** %argv, i64 1, !dbg !27
%0 = load i8*, i8** %arrayidx, align 8, !dbg !27, !tbaa !28
%call = tail call i32 (i8*, ...) bitcast (i32 (...)* @atoi to i32 (i8*, ...)*)(i8* %0) #4, !dbg !32
tail call void @llvm.dbg.value(metadata i32 %call, i64 0, metadata !14, metadata !20), !dbg !33
br label %if.end
if.end: ; preds = %if.else, %entry
%n.0 = phi i32 [ %call, %if.else ], [ 2, %entry ]
%call1 = tail call i32 @change(i32 %n.0) #4, !dbg !34
tail call void @llvm.dbg.value(metadata i32 %call1, i64 0, metadata !14, metadata !20), !dbg !33
%cmp2 = icmp sgt i32 %call1, 10, !dbg !35
br i1 %cmp2, label %if.then.3, label %if.else.5, !dbg !37
if.then.3: ; preds = %if.end
%call4 = tail call i32 @modify(i32 %call1) #4, !dbg !38
%add = add nsw i32 %call4, %call1, !dbg !40
br label %if.end.7, !dbg !41
if.else.5: ; preds = %if.end
%call6 = tail call i32 @inc(i32 %call1) #4, !dbg !42
br label %if.end.7
if.end.7: ; preds = %if.else.5, %if.then.3
%storemerge = phi i32 [ %call6, %if.else.5 ], [ %add, %if.then.3 ]
store i32 %storemerge, i32* @m, align 4, !dbg !43, !tbaa !44
%call8 = tail call i32 (i8*, ...) @printf(i8* nonnull getelementptr inbounds ([13 x i8], [13 x i8]* @.str, i64 0, i64 0), i32 %storemerge) #4, !dbg !46
ret i32 0, !dbg !47
}
declare i32 @atoi(...) #1
declare i32 @change(i32) #1
declare i32 @modify(i32) #1
declare i32 @inc(i32) #1
; Function Attrs: nounwind
declare i32 @printf(i8* nocapture readonly, ...) #2
; Function Attrs: nounwind readnone
declare void @llvm.dbg.value(metadata, i64, metadata, metadata) #3
attributes #0 = { nounwind uwtable }
attributes #1 = { nounwind }
attributes #2 = { nounwind }
attributes #3 = { nounwind readnone }
attributes #4 = { nounwind }
!llvm.dbg.cu = !{!0}
!llvm.module.flags = !{!17, !18}
!llvm.ident = !{!19}
!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang version 3.8.0 (trunk 253049) ", isOptimized: true, runtimeVersion: 0, emissionKind: 1, enums: !2, subprograms: !3, globals: !15)
!1 = !DIFile(filename: "LiveDebugValues.c", directory: "/home/vt/julia/test/tvvikram")
!2 = !{}
!3 = !{!4}
!4 = distinct !DISubprogram(name: "main", scope: !1, file: !1, line: 6, type: !5, isLocal: false, isDefinition: true, scopeLine: 6, flags: DIFlagPrototyped, isOptimized: true, variables: !11)
!5 = !DISubroutineType(types: !6)
!6 = !{!7, !7, !8}
!7 = !DIBasicType(name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
!8 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !9, size: 64, align: 64)
!9 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !10, size: 64, align: 64)
!10 = !DIBasicType(name: "char", size: 8, align: 8, encoding: DW_ATE_signed_char)
!11 = !{!12, !13, !14}
!12 = !DILocalVariable(name: "argc", arg: 1, scope: !4, file: !1, line: 6, type: !7)
!13 = !DILocalVariable(name: "argv", arg: 2, scope: !4, file: !1, line: 6, type: !8)
!14 = !DILocalVariable(name: "n", scope: !4, file: !1, line: 7, type: !7)
!15 = !{!16}
!16 = !DIGlobalVariable(name: "m", scope: !0, file: !1, line: 2, type: !7, isLocal: false, isDefinition: true, variable: i32* @m)
!17 = !{i32 2, !"Dwarf Version", i32 4}
!18 = !{i32 2, !"Debug Info Version", i32 3}
!19 = !{!"clang version 3.8.0 (trunk 253049)"}
!20 = !DIExpression()
!21 = !DILocation(line: 6, column: 14, scope: !4)
!22 = !DILocation(line: 6, column: 27, scope: !23)
!23 = !DILexicalBlockFile(scope: !4, file: !1, discriminator: 1)
!24 = !DILocation(line: 8, column: 12, scope: !25)
!25 = distinct !DILexicalBlock(scope: !4, file: !1, line: 8, column: 7)
!26 = !DILocation(line: 8, column: 7, scope: !4)
!27 = !DILocation(line: 11, column: 14, scope: !25)
!28 = !{!29, !29, i64 0}
!29 = !{!"any pointer", !30, i64 0}
!30 = !{!"omnipotent char", !31, i64 0}
!31 = !{!"Simple C/C++ TBAA"}
!32 = !DILocation(line: 11, column: 9, scope: !25)
!33 = !DILocation(line: 7, column: 7, scope: !23)
!34 = !DILocation(line: 12, column: 7, scope: !4)
!35 = !DILocation(line: 13, column: 9, scope: !36)
!36 = distinct !DILexicalBlock(scope: !4, file: !1, line: 13, column: 7)
!37 = !DILocation(line: 13, column: 7, scope: !4)
!38 = !DILocation(line: 14, column: 9, scope: !39)
!39 = distinct !DILexicalBlock(scope: !36, file: !1, line: 13, column: 15)
!40 = !DILocation(line: 15, column: 11, scope: !39)
!41 = !DILocation(line: 16, column: 3, scope: !39)
!42 = !DILocation(line: 18, column: 9, scope: !36)
!43 = !DILocation(line: 15, column: 7, scope: !39)
!44 = !{!45, !45, i64 0}
!45 = !{!"int", !30, i64 0}
!46 = !DILocation(line: 19, column: 3, scope: !4)
!47 = !DILocation(line: 20, column: 3, scope: !4)
...
---
name: main
alignment: 4
exposesReturnsTwice: false
hasInlineAsm: false
isSSA: false
tracksRegLiveness: true
tracksSubRegLiveness: false
liveins:
- { reg: '%edi' }
- { reg: '%rsi' }
calleeSavedRegisters: [ '%bh', '%bl', '%bp', '%bpl', '%bx', '%ebp', '%ebx',
'%rbp', '%rbx', '%r12', '%r13', '%r14', '%r15',
'%r12b', '%r13b', '%r14b', '%r15b', '%r12d', '%r13d',
'%r14d', '%r15d', '%r12w', '%r13w', '%r14w', '%r15w' ]
frameInfo:
isFrameAddressTaken: false
isReturnAddressTaken: false
hasStackMap: false
hasPatchPoint: false
stackSize: 8
offsetAdjustment: 0
maxAlignment: 0
adjustsStack: true
hasCalls: true
maxCallFrameSize: 0
hasOpaqueSPAdjustment: false
hasVAStart: false
hasMustTailInVarArgFunc: false
fixedStack:
- { id: 0, type: spill-slot, offset: -16, size: 8, alignment: 16, callee-saved-register: '%rbx' }
body: |
bb.0.entry:
successors: %bb.1.if.else(16), %bb.2.if.end(16)
liveins: %edi, %rsi, %rbx
frame-setup PUSH64r killed %rbx, implicit-def %rsp, implicit %rsp
CFI_INSTRUCTION .cfi_def_cfa_offset 16
CFI_INSTRUCTION .cfi_offset %rbx, -16
DBG_VALUE debug-use %edi, debug-use _, !12, !20, debug-location !21
DBG_VALUE debug-use %rsi, debug-use _, !13, !20, debug-location !22
%eax = MOV32rr %edi
DBG_VALUE debug-use %eax, debug-use _, !12, !20, debug-location !21
%edi = MOV32ri 2
CMP32ri8 killed %eax, 2, implicit-def %eflags, debug-location !26
JNE_1 %bb.2.if.end, implicit %eflags
bb.1.if.else:
successors: %bb.2.if.end(0)
liveins: %rsi
DBG_VALUE debug-use %rsi, debug-use _, !13, !20, debug-location !22
%rdi = MOV64rm killed %rsi, 1, _, 8, _, debug-location !27 :: (load 8 from %ir.arrayidx, !tbaa !28)
dead %eax = XOR32rr undef %eax, undef %eax, implicit-def dead %eflags, implicit-def %al, debug-location !32
CALL64pcrel32 @atoi, csr_64, implicit %rsp, implicit %rdi, implicit %al, implicit-def %rsp, implicit-def %eax, debug-location !32
%edi = MOV32rr %eax, debug-location !32
DBG_VALUE debug-use %edi, debug-use _, !14, !20, debug-location !33
bb.2.if.end:
successors: %bb.3.if.then.3(16), %bb.4.if.else.5(16)
liveins: %edi
CALL64pcrel32 @change, csr_64, implicit %rsp, implicit %edi, implicit-def %rsp, implicit-def %eax, debug-location !34
%ebx = MOV32rr %eax, debug-location !34
DBG_VALUE debug-use %ebx, debug-use _, !14, !20, debug-location !33
CMP32ri8 %ebx, 11, implicit-def %eflags, debug-location !37
JL_1 %bb.4.if.else.5, implicit killed %eflags, debug-location !37
bb.3.if.then.3:
successors: %bb.5.if.end.7(0)
liveins: %ebx
DBG_VALUE debug-use %ebx, debug-use _, !14, !20, debug-location !33
%edi = MOV32rr %ebx, debug-location !38
CALL64pcrel32 @modify, csr_64, implicit %rsp, implicit %edi, implicit-def %rsp, implicit-def %eax, debug-location !38
%ecx = MOV32rr %eax, debug-location !38
%ecx = ADD32rr killed %ecx, killed %ebx, implicit-def dead %eflags, debug-location !40
JMP_1 %bb.5.if.end.7
bb.4.if.else.5:
successors: %bb.5.if.end.7(0)
liveins: %ebx
DBG_VALUE debug-use %ebx, debug-use _, !14, !20, debug-location !33
%edi = MOV32rr killed %ebx, debug-location !42
CALL64pcrel32 @inc, csr_64, implicit %rsp, implicit %edi, implicit-def %rsp, implicit-def %eax, debug-location !42
%ecx = MOV32rr %eax, debug-location !42
bb.5.if.end.7:
liveins: %ecx
MOV32mr %rip, 1, _, @m, _, %ecx, debug-location !43 :: (store 4 into @m, !tbaa !44)
dead undef %edi = MOV32ri64 @.str, implicit-def %rdi, debug-location !46
dead %eax = XOR32rr undef %eax, undef %eax, implicit-def dead %eflags, implicit-def %al, debug-location !47
%esi = MOV32rr killed %ecx, debug-location !46
CALL64pcrel32 @printf, csr_64, implicit %rsp, implicit %rdi, implicit %esi, implicit %al, implicit-def %rsp, implicit-def dead %eax, debug-location !46
%eax = XOR32rr undef %eax, undef %eax, implicit-def dead %eflags, debug-location !47
%rbx = POP64r implicit-def %rsp, implicit %rsp, debug-location !47
RETQ %eax, debug-location !47
...

live-debug-values.ll

; RUN: llc -filetype=asm %s -o - | FileCheck %s
; Test the extension of debug ranges from predecessors.
; Generated from the source file LiveDebugValues.c:
; #include <stdio.h>
; int m;
; extern int inc(int n);
; extern int change(int n);
; extern int modify(int n);
; int main(int argc, char **argv) {
; int n;
; if (argc != 2)
; n = 2;
; else
; n = atoi(argv[1]);
; n = change(n);
; if (n > 10) {
; m = modify(n);
; m = m + n; // var `m' doesn't has a dbg.value
; }
; else
; m = inc(n); // var `m' doesn't has a dbg.value
; printf("m(main): %d\n", m);
; return 0;
; }
; with clang -g -O3 -emit-llvm -c LiveDebugValues.c -S -o live-debug-values.ll
; This case will also produce multiple locations but only the debug range
; extension is tested here.
; DBG_VALUE for variable "n" is extended into BB#5 from its predecessors BB#3
; and BB#4.
; CHECK: .LBB0_5:
; CHECK-NEXT: #DEBUG_VALUE: main:argv <- %RSI
; CHECK-NEXT: #DEBUG_VALUE: main:n <- %EBX
; ModuleID = 'LiveDebugValues.c'
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
@m = common global i32 0, align 4
@.str = private unnamed_addr constant [13 x i8] c"m(main): %d\0A\00", align 1
; Function Attrs: nounwind uwtable
define i32 @main(i32 %argc, i8** nocapture readonly %argv) #0 !dbg !4 {
entry:
tail call void @llvm.dbg.value(metadata i32 %argc, i64 0, metadata !12, metadata !20), !dbg !21
tail call void @llvm.dbg.value(metadata i8** %argv, i64 0, metadata !13, metadata !20), !dbg !22
%cmp = icmp eq i32 %argc, 2, !dbg !24
br i1 %cmp, label %if.else, label %if.end, !dbg !26
if.else: ; preds = %entry
%arrayidx = getelementptr inbounds i8*, i8** %argv, i64 1, !dbg !27
%0 = load i8*, i8** %arrayidx, align 8, !dbg !27, !tbaa !28
%call = tail call i32 (i8*, ...) bitcast (i32 (...)* @atoi to i32 (i8*, ...)*)(i8* %0) #4, !dbg !32
tail call void @llvm.dbg.value(metadata i32 %call, i64 0, metadata !14, metadata !20), !dbg !33
br label %if.end
if.end: ; preds = %entry, %if.else
%n.0 = phi i32 [ %call, %if.else ], [ 2, %entry ]
%call1 = tail call i32 @change(i32 %n.0) #4, !dbg !34
tail call void @llvm.dbg.value(metadata i32 %call1, i64 0, metadata !14, metadata !20), !dbg !33
%cmp2 = icmp sgt i32 %call1, 10, !dbg !35
br i1 %cmp2, label %if.then.3, label %if.else.5, !dbg !37
if.then.3: ; preds = %if.end
%call4 = tail call i32 @modify(i32 %call1) #4, !dbg !38
%add = add nsw i32 %call4, %call1, !dbg !40
br label %if.end.7, !dbg !41
if.else.5: ; preds = %if.end
%call6 = tail call i32 @inc(i32 %call1) #4, !dbg !42
br label %if.end.7
if.end.7: ; preds = %if.else.5, %if.then.3
%storemerge = phi i32 [ %call6, %if.else.5 ], [ %add, %if.then.3 ]
store i32 %storemerge, i32* @m, align 4, !dbg !43, !tbaa !44
%call8 = tail call i32 (i8*, ...) @printf(i8* nonnull getelementptr inbounds ([13 x i8], [13 x i8]* @.str, i64 0, i64 0), i32 %storemerge) #4, !dbg !46
ret i32 0, !dbg !47
}
declare i32 @atoi(...) #1
declare i32 @change(i32) #1
declare i32 @modify(i32) #1
declare i32 @inc(i32) #1
; Function Attrs: nounwind
declare i32 @printf(i8* nocapture readonly, ...) #2
; Function Attrs: nounwind readnone
declare void @llvm.dbg.value(metadata, i64, metadata, metadata) #3
attributes #0 = { nounwind uwtable }
attributes #1 = { nounwind }
attributes #2 = { nounwind }
attributes #3 = { nounwind readnone }
attributes #4 = { nounwind }
!llvm.dbg.cu = !{!0}
!llvm.module.flags = !{!17, !18}
!llvm.ident = !{!19}
!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang version 3.8.0 (trunk 253049) ", isOptimized: true, runtimeVersion: 0, emissionKind: 1, enums: !2, subprograms: !3, globals: !15)
!1 = !DIFile(filename: "LiveDebugValues.c", directory: "/home/vt/julia/test/tvvikram")
!2 = !{}
!3 = !{!4}
!4 = distinct !DISubprogram(name: "main", scope: !1, file: !1, line: 6, type: !5, isLocal: false, isDefinition: true, scopeLine: 6, flags: DIFlagPrototyped, isOptimized: true, variables: !11)
!5 = !DISubroutineType(types: !6)
!6 = !{!7, !7, !8}
!7 = !DIBasicType(name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
!8 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !9, size: 64, align: 64)
!9 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !10, size: 64, align: 64)
!10 = !DIBasicType(name: "char", size: 8, align: 8, encoding: DW_ATE_signed_char)
!11 = !{!12, !13, !14}
!12 = !DILocalVariable(name: "argc", arg: 1, scope: !4, file: !1, line: 6, type: !7)
!13 = !DILocalVariable(name: "argv", arg: 2, scope: !4, file: !1, line: 6, type: !8)
!14 = !DILocalVariable(name: "n", scope: !4, file: !1, line: 7, type: !7)
!15 = !{!16}
!16 = !DIGlobalVariable(name: "m", scope: !0, file: !1, line: 2, type: !7, isLocal: false, isDefinition: true, variable: i32* @m)
!17 = !{i32 2, !"Dwarf Version", i32 4}
!18 = !{i32 2, !"Debug Info Version", i32 3}
!19 = !{!"clang version 3.8.0 (trunk 253049) "}
!20 = !DIExpression()
!21 = !DILocation(line: 6, column: 14, scope: !4)
!22 = !DILocation(line: 6, column: 27, scope: !23)
!23 = !DILexicalBlockFile(scope: !4, file: !1, discriminator: 1)
!24 = !DILocation(line: 8, column: 12, scope: !25)
!25 = distinct !DILexicalBlock(scope: !4, file: !1, line: 8, column: 7)
!26 = !DILocation(line: 8, column: 7, scope: !4)
!27 = !DILocation(line: 11, column: 14, scope: !25)
!28 = !{!29, !29, i64 0}
!29 = !{!"any pointer", !30, i64 0}
!30 = !{!"omnipotent char", !31, i64 0}
!31 = !{!"Simple C/C++ TBAA"}
!32 = !DILocation(line: 11, column: 9, scope: !25)
!33 = !DILocation(line: 7, column: 7, scope: !23)
!34 = !DILocation(line: 12, column: 7, scope: !4)
!35 = !DILocation(line: 13, column: 9, scope: !36)
!36 = distinct !DILexicalBlock(scope: !4, file: !1, line: 13, column: 7)
!37 = !DILocation(line: 13, column: 7, scope: !4)
!38 = !DILocation(line: 14, column: 9, scope: !39)
!39 = distinct !DILexicalBlock(scope: !36, file: !1, line: 13, column: 15)
!40 = !DILocation(line: 15, column: 11, scope: !39)
!41 = !DILocation(line: 16, column: 3, scope: !39)
!42 = !DILocation(line: 18, column: 9, scope: !36)
!43 = !DILocation(line: 15, column: 7, scope: !39)
!44 = !{!45, !45, i64 0}
!45 = !{!"int", !30, i64 0}
!46 = !DILocation(line: 19, column: 3, scope: !4)
!47 = !DILocation(line: 20, column: 3, scope: !4)
MIR/X86/live-debug-values-3preds.mir