Page MenuHomePhabricator

Remove datalayout and target triple from test cases related to LiveDebugValues pass.
AbandonedPublic

Authored by tvvikram on Dec 16 2015, 9:10 AM.

Details

Reviewers
aprantl
Summary

Buildbots failed with architectures other than x86 for a new test case added in commit rL255759.
The test case contained x86 specific target triple - 'x86_64-unknown-linux-gnu' as seen from http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/8377/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3Alive-debug-values.ll.

I have removed the datalayout and target triple lines from the test case (including related test cases). This made the test cases "generic" i.e. moved the test cases into "Generic" folder.

Diff Detail

Event Timeline

tvvikram updated this revision to Diff 43015.Dec 16 2015, 9:10 AM
tvvikram retitled this revision from to Remove datalayout and target triple from test cases related to LiveDebugValues pass..
tvvikram updated this object.
tvvikram added a reviewer: aprantl.
tvvikram added a subscriber: loladiro.

The testcase is still x86-specific, since it checks for x86 register names. The Hexagon build bot only builds the Hexagon target.

I just did

$ bin/llc -march=hexagon -filetype=asm ../llvm/test/DebugInfo/live-debug-values.ll -o - | bin/FileCheck ../llvm/test/DebugInfo/live-debug-values.ll
../llvm/test/DebugInfo/live-debug-values.ll:32:10: error: expected string not found in input
; CHECK: .LBB0_5:
         ^
<stdin>:1:2: note: scanning from here
 .text
 ^
<stdin>:70:1: note: possible intended match here
.LBB0_2: // %if.else.5
^

so it seems your test case is still to x86-specific.

tvvikram updated this revision to Diff 43039.Dec 16 2015, 11:05 AM

Retained the test cases in X86 folder as they are not generic.

LGTM conceptually. The patch doesn't apply to the current repo though (I guess it's a diff against what you had locally).

aprantl edited edge metadata.Dec 16 2015, 12:53 PM

The right fix for this is to move the test to an X86 subdirectory and add a lit.local.cfg file like the one in test/DebugInfo/X86/.

MIR/X86/live-debug-values-3preds.mir
36

Since you are actually checking for x86 register names I don't see the point in removing the target triple from the test. I would just leave it in.

tvvikram added inline comments.Dec 16 2015, 6:04 PM
MIR/X86/live-debug-values-3preds.mir
36

I checked a few existing test cases in DebugInfo/X86 and they didn't contain the triple. So I had removed it.

Fixed by chapuni in rL255834. Will abandon this patch.

tvvikram abandoned this revision.Dec 16 2015, 6:13 PM