This is an archive of the discontinued LLVM Phabricator instance.

[X86] Add missing m64/int64 conversions
ClosedPublic

Authored by mkuper on Dec 16 2015, 6:50 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

mkuper updated this revision to Diff 43006.Dec 16 2015, 6:50 AM
mkuper retitled this revision from to [X86] Add missing m64/int64 conversions.
mkuper updated this object.
mkuper added reviewers: AsafBadouh, delena.
mkuper added a subscriber: llvm-commits.
delena accepted this revision.Dec 17 2015, 4:44 AM
delena edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 17 2015, 4:44 AM
delena added inline comments.Dec 17 2015, 4:46 AM
lib/Headers/mmintrin.h
446 ↗(On Diff #43006)

Under X86_64 or always?

Thanks, Elena.

lib/Headers/mmintrin.h
446 ↗(On Diff #43006)

Good question. I mean, _m_to_int64 and _mm_cvtm64_si64 are always equivalent, but perhaps both ought to be available only on x86_64.
In any case, right now _mm_cvtm64_si64 is always available, so I'd rather leave it as is. Possibly both should be desiabled for i686 in a separate commit.

This revision was automatically updated to reflect the committed changes.