[Windows] This fixes modules to enable generation of size files

[omjavaid]

Summary

LLVM testsuite was unable to generate size file on windows because of abnormal path generation and permission issues.
This patch fixes both these issues by allowing creation of copy instead of symlinks on windows and using SHELL_PATH cmake
expression for fixing size file path on windows.

[mstorsjo]

cmake/modules/CopyDir.cmake

29

This bit looks straightforward and obviously correct.

cmake/modules/TestSuite.cmake

69

Can you elaborate (extend the description of the patch/commit message) about what the paths looked like before and what they look like after SHELL_PATH?

cmake/modules/CopyDir.cmake

 
 function(llvm_copy target to from)
   add_custom_command(
     TARGET ${target} POST_BUILD
     COMMAND ${CMAKE_COMMAND} -E copy ${from} ${to}
   )
 endfunction()
 
+# On Windows create_symlink requires special permissions. Use copy_if_different instead.
+if(CMAKE_HOST_WIN32)
+  set(_link_or_copy copy_if_different)
+else()
+  set(_link_or_copy create_symlink)
+endif()
+
 function(llvm_create_symlink target to from)
   add_custom_command(
     TARGET ${target} POST_BUILD
-    COMMAND ${CMAKE_COMMAND} -E create_symlink ${from} ${to}
+    COMMAND ${CMAKE_COMMAND} -E ${_link_or_copy} ${from} ${to}
   )
 endfunction()
 
 function(llvm_make_directory target)
   add_custom_command(
     TARGET ${target} POST_BUILD
     COMMAND ${CMAKE_COMMAND} -E make_directory ${ARGN}
   )
 endfunction()

cmake/modules/TestSuite.cmake

function(llvm_test_executable_no_test target)
   endif()
 
   llvm_codesign(${target})
   set_property(GLOBAL APPEND PROPERTY TEST_SUITE_TARGETS ${target})
   test_suite_add_build_dependencies(${target})
 
   if(TEST_SUITE_LLVM_SIZE)
     add_custom_command(TARGET ${target} POST_BUILD
-      COMMAND ${TEST_SUITE_LLVM_SIZE} --format=sysv $<TARGET_FILE:${target}>
-      > $<TARGET_FILE:${target}>.size)
+      COMMAND ${TEST_SUITE_LLVM_SIZE} --format=sysv $<SHELL_PATH:$<TARGET_FILE:${target}>>
+      > $<SHELL_PATH:$<TARGET_FILE:${target}>>.size)
   endif()
 endfunction()
 
 # Creates a new executable build target. Use this instead of `add_executable`.
 # It applies CFLAGS, CPPFLAGS, CXXFLAGS, FFLAGS and LDFLAGS. Creates a .test
 # file if necessary, registers the target with the TEST_SUITE_TARGETS list and
 # makes sure we build the required dependencies for compiletime measurements
 # and support the TEST_SUITE_PROFILE_USE mode.