This is an archive of the discontinued LLVM Phabricator instance.

[Polly] Fix delinearization of fortran arrays
ClosedPublic

Authored by gareevroman on Dec 16 2015, 4:44 AM.

Details

Summary

This patch fixes processing of unsigned maximum and signed maximum operations
from r253995 and Bug 25759.

Diff Detail

Repository
rL LLVM

Event Timeline

gareevroman retitled this revision from to [Polly] Fix delinearization of fortran arrays.
gareevroman updated this object.
gareevroman added a subscriber: pollydev.
grosser accepted this revision.Dec 16 2015, 5:20 AM
grosser edited edge metadata.

Hi Roman,

thanks for this patch. I only have some minor comments. I suggest you explain in the commit message briefly the issues resolved. Also, the test case could be slightly improved.

Otherwise, this LGTM. Feel free to commit after having addressed my comments.

Best,
Tobias

test/ScopDetect/scev_remove_max.ll
13 ↗(On Diff #42989)
  • Run -instnamer over the test case.
  • Add a FileCheck line that ensures we actually detect the region (Otherwise we may loose this test case over time)
  • Add a brief comment what is tested.
This revision is now accepted and ready to land.Dec 16 2015, 5:20 AM
This revision was automatically updated to reflect the committed changes.