This is an archive of the discontinued LLVM Phabricator instance.

Differential D155576

[NFC][clang-extdef-mapping] fix test failure on nonsupported targets
ClosedPublic

Authored by danix800 on Jul 18 2023, 4:03 AM.

Details

Reviewers
None
Commits
rGc24f0f9bd6f4: [NFC][clang-extdef-mapping] fix test failure on unsupported targets
Summary

ms-stlye asm block is not supported on targets like arm/hexagon.
Specify a working target as POC.

Introduced by https://reviews.llvm.org/D154983

Diff Detail

Event Timeline

danix800 created this revision.Jul 18 2023, 4:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2023, 4:03 AM
danix800 requested review of this revision.Jul 18 2023, 4:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2023, 4:03 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
danix800 edited the summary of this revision. (Show Details)Jul 18 2023, 4:04 AM
Herald added a subscriber: kristof.beyls. · View Herald TranscriptJul 18 2023, 4:04 AM
danix800 edited the summary of this revision. (Show Details)Jul 18 2023, 4:07 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 18 2023, 4:57 AM
This revision was landed with ongoing or failed builds.
Closed by commit rGc24f0f9bd6f4: [NFC][clang-extdef-mapping] fix test failure on unsupported targets (authored by dingfei <fding@feysh.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
dingfei <fding@feysh.com> added a commit: rGc24f0f9bd6f4: [NFC][clang-extdef-mapping] fix test failure on unsupported targets.
Harbormaster completed remote builds in B246157: Diff 541437.Jul 18 2023, 11:25 AM

Revision Contents

PathSize
clang/
test/
Tooling/
6 lines

Diff 541437

clang/test/Tooling/ms-asm-clang-extdef-mapping.c

// RUN: clang-extdef-mapping "%s" -- -fasm-blocks 2>&1 | FileCheck %s // RUN: clang-extdef-mapping "%s" -- -fasm-blocks \
// RUN: -target x86_64-apple-darwin10 2>&1 | FileCheck %s
// REQUIRES: x86-registered-target
void Break() { void Break() {
__asm { int 3 } __asm { int 3 }
} }
// CHECK: {{c:@F@Break .*}} // CHECK: {{10:c:@F@Break}}