This is an archive of the discontinued LLVM Phabricator instance.

Differential D155553

[libcxx] [test] Remove a stray double space from a test config. NFC.
ClosedPublic

Authored by mstorsjo on Jul 18 2023, 12:41 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGf9e54a5c0f29: [libcxx] [test] Remove a stray double space from a test config. NFC.
Summary

Based on a patch by Andrew Ng.

Diff Detail

Event Timeline

mstorsjo created this revision.Jul 18 2023, 12:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2023, 12:41 AM
mstorsjo requested review of this revision.Jul 18 2023, 12:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2023, 12:41 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
mstorsjo mentioned this in D144734: [libcxx] Enable support for static and debug Windows runtimes.Jul 18 2023, 1:13 AM
Harbormaster completed remote builds in B246097: Diff 541358.Jul 18 2023, 5:02 AM
ldionne accepted this revision.Jul 18 2023, 6:35 AM
ldionne added a subscriber: ldionne.

Ignore the CI failure, I think we have to look into it separately,

This revision is now accepted and ready to land.Jul 18 2023, 6:35 AM
This revision was landed with ongoing or failed builds.Jul 19 2023, 1:32 AM
Closed by commit rGf9e54a5c0f29: [libcxx] [test] Remove a stray double space from a test config. NFC. (authored by andrewng, committed by mstorsjo). · Explain Why
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rGf9e54a5c0f29: [libcxx] [test] Remove a stray double space from a test config. NFC..

Revision Contents

PathSize
libcxx/
test/
configs/
2 lines

Diff 541885

libcxx/test/configs/llvm-libc++-shared-no-vcruntime-clangcl.cfg.in

# This testing configuration handles running the test suite against LLVM's libc++ # This testing configuration handles running the test suite against LLVM's libc++
# using a DLL, with Clang-cl on Windows. This variant sets _HAS_EXCEPTIONS = 0 # using a DLL, with Clang-cl on Windows. This variant sets _HAS_EXCEPTIONS = 0
# which removes exception class definitions from the vcruntime. # which removes exception class definitions from the vcruntime.
lit_config.load_config(config, '@CMAKE_CURRENT_BINARY_DIR@/cmake-bridge.cfg') lit_config.load_config(config, '@CMAKE_CURRENT_BINARY_DIR@/cmake-bridge.cfg')
config.substitutions.append(('%{flags}', '--driver-mode=g++')) config.substitutions.append(('%{flags}', '--driver-mode=g++'))
config.substitutions.append(('%{compile_flags}', config.substitutions.append(('%{compile_flags}',
'-nostdinc++ -I %{include} -I %{target-include} -I %{libcxx}/test/support -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_STDIO_ISO_WIDE_SPECIFIERS -DNOMINMAX -D_HAS_EXCEPTIONS=0' '-nostdinc++ -I %{include} -I %{target-include} -I %{libcxx}/test/support -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_STDIO_ISO_WIDE_SPECIFIERS -DNOMINMAX -D_HAS_EXCEPTIONS=0'
)) ))
config.substitutions.append(('%{link_flags}', config.substitutions.append(('%{link_flags}',
Show All 15 Lines