This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Implement stringstream members of P0408R7 (Efficient Access to basic_stringbuf's Buffer)
ClosedPublic

Authored by pfusik on Jul 15 2023, 2:01 AM.

Diff Detail

Event Timeline

pfusik created this revision.Jul 15 2023, 2:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2023, 2:01 AM
pfusik requested review of this revision.Jul 15 2023, 2:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2023, 2:01 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Together with https://reviews.llvm.org/D155276 this concludes the paper implementation.
I didn't update the docs yet as that would conflict with https://reviews.llvm.org/D155276
(and I don't feel confident to use chained patches at this point)

pfusik updated this revision to Diff 540731.Jul 15 2023, 12:39 PM

Added a constructor constraint.

Mordante accepted this revision.Jul 16 2023, 6:27 AM

(and I don't feel confident to use chained patches at this point)

Normally I would encourage you to try it. However in about 2 months we'll move the GitHub, so it's not that important.

LGTM with one request.

libcxx/include/sstream
224–237

Can you do this as a drive-by improvement?

1108

Note to self, this one is constrained again.

This revision is now accepted and ready to land.Jul 16 2023, 6:27 AM
pfusik updated this revision to Diff 540805.Jul 16 2023, 6:35 AM
pfusik marked an inline comment as done.

Rebased. Updated the status docs. A whitespace fix.