This is an archive of the discontinued LLVM Phabricator instance.

Welcome to NetBSD signals
ClosedPublic

Authored by krytarowski on Dec 13 2015, 7:49 AM.

Details

Summary

Signals 1-32 are matching the default UNIX platform.

There are platform specific ones above 32.

From the /usr/include/sys/signal.h header:

#define SIGPWR          32      /* power fail/restart (not reset when caught) */
#ifdef _KERNEL
#define SIGRTMIN        33      /* Kernel only; not exposed to userland yet */
#define SIGRTMAX        63      /* Kernel only; not exposed to userland yet */
#endif

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski retitled this revision from to Welcome to NetBSD signals.
krytarowski updated this object.
krytarowski added reviewers: joerg, emaste.
krytarowski set the repository for this revision to rL LLVM.
krytarowski added a subscriber: lldb-commits.
joerg accepted this revision.Dec 14 2015, 4:58 AM
joerg edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 14 2015, 4:58 AM
emaste added inline comments.Dec 14 2015, 7:00 AM
source/Plugins/Process/Utility/CMakeLists.txt
6

Should keep these in alpha order

source/Target/UnixSignals.cpp
66–67

Not part of your change, but just spotted it during this review; The default case should probably be used for OpenBSD. We can change it later.

Thank you. After fixing the order I'm going to land this diff.

source/Plugins/Process/Utility/CMakeLists.txt
6

Good catch.

krytarowski added inline comments.Dec 14 2015, 4:04 PM
source/Target/UnixSignals.cpp
66–67

I will leave it as it is.

krytarowski edited edge metadata.

Improve abc order of source files

krytarowski closed this revision.Dec 14 2015, 4:53 PM