This is an archive of the discontinued LLVM Phabricator instance.

Differential D154538

[scudo] SCUDO_FUCHSIA uses ReservedMemoryDefault
ClosedPublic

Authored by Caslyn on Jul 5 2023, 11:53 AM.

Details

Reviewers
Chia-hungDuan
Commits
rG4a5d6267832f: [scudo] SCUDO_FUCHSIA uses ReservedMemoryDefault
Summary

Some Fuchsia zx tests failed from https://reviews.llvm.org/D153888:
https://turquoise-internal-review.git.corp.google.com/c/integration/+/729619

Use ReservedMemoryDefault for SCUDO_FUCHSIA to use the default
MemMap API, while test failures are debugged.

Diff Detail

Event Timeline

Caslyn created this revision.Jul 5 2023, 11:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2023, 11:53 AM
Herald added subscribers: yaneury, Chia-hungDuan, Enna1, cryptoad. · View Herald Transcript
Caslyn requested review of this revision.Jul 5 2023, 11:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2023, 11:54 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Chia-hungDuan accepted this revision.Jul 5 2023, 11:55 AM
This revision is now accepted and ready to land.Jul 5 2023, 11:55 AM
Harbormaster completed remote builds in B243282: Diff 537454.Jul 5 2023, 12:16 PM
Caslyn updated this revision to Diff 537467.Jul 5 2023, 12:48 PM

rebased

Harbormaster completed remote builds in B243289: Diff 537467.Jul 5 2023, 1:11 PM
Closed by commit rG4a5d6267832f: [scudo] SCUDO_FUCHSIA uses ReservedMemoryDefault (authored by Caslyn). · Explain WhyJul 5 2023, 1:22 PM
This revision was automatically updated to reflect the committed changes.
Caslyn added a commit: rG4a5d6267832f: [scudo] SCUDO_FUCHSIA uses ReservedMemoryDefault.
fabio-d mentioned this in D156800: [scudo] Enable MemMapFuchsia.Aug 1 2023, 7:49 AM
fabio-d mentioned this in rG145a9290c2ec: [scudo] Enable MemMapFuchsia.Aug 1 2023, 3:33 PM

Revision Contents

PathSize
compiler-rt/
lib/
scudo/
standalone/
2 lines

Diff 537477

compiler-rt/lib/scudo/standalone/mem_map.h

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Linesprivate:
uptr Capacity = 0; uptr Capacity = 0;
MapPlatformData Data = {}; MapPlatformData Data = {};
}; };
#if SCUDO_LINUX #if SCUDO_LINUX
using ReservedMemoryT = ReservedMemoryDefault; using ReservedMemoryT = ReservedMemoryDefault;
using MemMapT = ReservedMemoryT::MemMapT; using MemMapT = ReservedMemoryT::MemMapT;
#elif SCUDO_FUCHSIA #elif SCUDO_FUCHSIA
using ReservedMemoryT = ReservedMemoryFuchsia; using ReservedMemoryT = ReservedMemoryDefault;
using MemMapT = ReservedMemoryT::MemMapT; using MemMapT = ReservedMemoryT::MemMapT;
#elif SCUDO_TRUSTY #elif SCUDO_TRUSTY
using ReservedMemoryT = ReservedMemoryDefault; using ReservedMemoryT = ReservedMemoryDefault;
using MemMapT = ReservedMemoryT::MemMapT; using MemMapT = ReservedMemoryT::MemMapT;
#else #else
#error \ #error \
"Unsupported platform, please implement the ReservedMemory for your platform!" "Unsupported platform, please implement the ReservedMemory for your platform!"
#endif #endif
} // namespace scudo } // namespace scudo
#endif // SCUDO_MEM_MAP_H_ #endif // SCUDO_MEM_MAP_H_