This is an archive of the discontinued LLVM Phabricator instance.

[lldb][NFCI] Minor cleanup of default OptionValue::GetSubValue implementation
ClosedPublic

Authored by bulbazord on Jul 3 2023, 1:42 PM.

Details

Summary

This does 2 things:

  • Corrects a minor typo (value subvalue -> valid subvalue)
  • Removes an unnecessary instance of str().c_str() (creating a temporary std::string from a StringRef just to get a valid null-terminated string).

Diff Detail

Event Timeline

bulbazord created this revision.Jul 3 2023, 1:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 1:42 PM
bulbazord requested review of this revision.Jul 3 2023, 1:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 1:42 PM
mib accepted this revision.Jul 3 2023, 1:42 PM
This revision is now accepted and ready to land.Jul 3 2023, 1:42 PM