This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
libcxx/docs/Status/
-
docs/
-
Status/
-
Cxx2cIssues.csv

Differential D154381

[libc++] Mark LWG2994 as complete and remove Clang from the version
ClosedPublic

Authored by philnik on Jul 3 2023, 10:57 AM.

Download Raw Diff

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rG75f6af82c38e: [libc++] Mark LWG2994 as complete and remove Clang from the version

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

philnik created this revision.Jul 3 2023, 10:57 AM

Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 10:57 AM

philnik requested review of this revision.Jul 3 2023, 10:57 AM

Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 10:57 AM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

string_view added it in LLVM 5

Do we have a test? If not, let's add one, otherwise LGTM

This revision is now accepted and ready to land.Jul 3 2023, 12:56 PM

In D154381#4469491, @ldionne wrote:

Do we have a test? If not, let's add one, otherwise LGTM

We do. It's libcxx/test/std/strings/basic.string/traits_mismatch.verify.cpp.

Harbormaster completed remote builds in B242861: Diff 536846.Jul 3 2023, 2:50 PM

Closed by commit rG75f6af82c38e: [libc++] Mark LWG2994 as complete and remove Clang from the version (authored by philnik). · Explain WhyJul 5 2023, 2:43 PM

This revision was automatically updated to reflect the committed changes.

philnik added a commit: rG75f6af82c38e: [libc++] Mark LWG2994 as complete and remove Clang from the version.

Revision Contents

Path

Size

libcxx/

docs/

Status/

Cxx2cIssues.csv

2 lines

Diff 537510

libcxx/docs/Status/Cxx2cIssues.csv

	"Issue #","Issue Name","Meeting","Status","First released version","Labels"			"Issue #","Issue Name","Meeting","Status","First released version","Labels"
	"`2994 <https://wg21.link/LWG2994>`__","Needless UB for ``basic_string`` and ``basic_string_view``","Varna June 2023","","",""			"`2994 <https://wg21.link/LWG2994>`__","Needless UB for ``basic_string`` and ``basic_string_view``","Varna June 2023","\|Complete\|","5.0",""
	"`3884 <https://wg21.link/LWG3884>`__","``flat_foo`` is missing allocator-extended copy/move constructors","Varna June 2023","","","\|flat_containers\|"			"`3884 <https://wg21.link/LWG3884>`__","``flat_foo`` is missing allocator-extended copy/move constructors","Varna June 2023","","","\|flat_containers\|"
	"`3885 <https://wg21.link/LWG3885>`__","``op`` should be in [zombie.names]","Varna June 2023","","",""			"`3885 <https://wg21.link/LWG3885>`__","``op`` should be in [zombie.names]","Varna June 2023","","",""
	"`3887 <https://wg21.link/LWG3887>`__","Version macro for ``allocate_at_least``","Varna June 2023","","",""			"`3887 <https://wg21.link/LWG3887>`__","Version macro for ``allocate_at_least``","Varna June 2023","","",""
	"`3893 <https://wg21.link/LWG3893>`__","LWG 3661 broke ``atomic<shared_ptr<T>> a; a = nullptr;``","Varna June 2023","","",""			"`3893 <https://wg21.link/LWG3893>`__","LWG 3661 broke ``atomic<shared_ptr<T>> a; a = nullptr;``","Varna June 2023","","",""
	"`3894 <https://wg21.link/LWG3894>`__","``generator::promise_type::yield_value(ranges::elements_of<Rng, Alloc>)`` should not be ``noexcept``","Varna June 2023","","",""			"`3894 <https://wg21.link/LWG3894>`__","``generator::promise_type::yield_value(ranges::elements_of<Rng, Alloc>)`` should not be ``noexcept``","Varna June 2023","","",""
	"`3903 <https://wg21.link/LWG3903>`__","span destructor is redundantly noexcept","Varna June 2023","","",""			"`3903 <https://wg21.link/LWG3903>`__","span destructor is redundantly noexcept","Varna June 2023","","",""
	"`3904 <https://wg21.link/LWG3904>`__","``lazy_split_view::outer-iterator``'s const-converting constructor isn't setting ``trailing_empty_``","Varna June 2023","","","\|ranges\|"			"`3904 <https://wg21.link/LWG3904>`__","``lazy_split_view::outer-iterator``'s const-converting constructor isn't setting ``trailing_empty_``","Varna June 2023","","","\|ranges\|"
	"`3905 <https://wg21.link/LWG3905>`__","Type of ``std::fexcept_t``","Varna June 2023","","",""			"`3905 <https://wg21.link/LWG3905>`__","Type of ``std::fexcept_t``","Varna June 2023","","",""
	Show All 12 Lines