This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Use this in lamba capture in <latch>
ClosedPublic

Authored by diamante0018 on Jul 3 2023, 8:33 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG0529025648b5: [libc++] Use this in lamba capture in <latch>
Summary

"&" seemed to be used in a situation where perhaps it's not the best option.
Other libc++ modules make use of [this] when calling functions from the same class.
[this] would be the appropriate lambda capture specifier to use in this situation.

Diff Detail

Event Timeline

diamante0018 created this revision.Jul 3 2023, 8:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 8:33 AM
diamante0018 requested review of this revision.Jul 3 2023, 8:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 8:33 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jul 3 2023, 10:41 AM
ldionne added a subscriber: ldionne.

Ignore the CI failures, those are a CI infra issue.

This revision is now accepted and ready to land.Jul 3 2023, 10:41 AM

Hello, thanks for accepting. This would be my first contribution. Do I need to do anything else or will the bot merge this automatically. Thanks.

diamante0018 edited the summary of this revision. (Show Details)Jul 4 2023, 4:26 AM

Hello, thanks for accepting. This would be my first contribution. Do I need to do anything else or will the bot merge this automatically. Thanks.

Can you provide your name and email address, then we will land the patch on your behalf.

Hello, thanks for accepting. This would be my first contribution. Do I need to do anything else or will the bot merge this automatically. Thanks.

Thanks for your first contribution by the way!

Hello, thanks for accepting. This would be my first contribution. Do I need to do anything else or will the bot merge this automatically. Thanks.

Can you provide your name and email address, then we will land the patch on your behalf.

Edoardo Sanguineti edoardo.sanguineti222@gmail.com

Thanks

This revision was landed with ongoing or failed builds.Jul 4 2023, 11:44 AM
This revision was automatically updated to reflect the committed changes.

Hello, thanks for accepting. This would be my first contribution. Do I need to do anything else or will the bot merge this automatically. Thanks.

Can you provide your name and email address, then we will land the patch on your behalf.

Edoardo Sanguineti edoardo.sanguineti222@gmail.com

Thanks

I've landed the patch on your behalf. Thanks for your first contribution!