This is an archive of the discontinued LLVM Phabricator instance.

[llvm][TableGen][Jupyter] Record current python when kernel is installed
ClosedPublic

Authored by DavidSpickett on Jul 3 2023, 7:55 AM.

Details

Summary

Previously the kernel.json would always point to python3 even if you
installed using a python from a virtualenv. This meant that tools like VSCode
would try to run the kernel against the system python and fail.

Added a note to the readme about it. I've removed the need to
add to PYTHONPTHON as well, turns out it wasn't needed.

This fixes an issue reported in https://discourse.llvm.org/t/tablegen-the-playground-ipynb-file-is-not-working-as-expected/71745.

Diff Detail

Event Timeline

DavidSpickett created this revision.Jul 3 2023, 7:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 7:55 AM
DavidSpickett requested review of this revision.Jul 3 2023, 7:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 7:55 AM

Remove the very proffesional runtime error I was using to check PYTHONPATH wasn't needed :).

DavidSpickett edited the summary of this revision. (Show Details)
awarzynski accepted this revision.Jul 4 2023, 1:48 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 4 2023, 1:48 PM
llvm/utils/TableGen/jupyter/README.md