This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Add test cases from PR63321. NFC.
ClosedPublic

Authored by dtcxzyw on Jun 30 2023, 12:06 AM.

Details

Diff Detail

Event Timeline

dtcxzyw created this revision.Jun 30 2023, 12:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2023, 12:06 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
dtcxzyw requested review of this revision.Jun 30 2023, 12:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2023, 12:06 AM
dtcxzyw added inline comments.Jun 30 2023, 12:59 AM
llvm/test/Transforms/InstCombine/binop-cast.ll
303

I am not sure that it should not be folded into select.

D153148 folds it into select and seems to generate better instruction seq.

x86-64: https://godbolt.org/z/jv9v9xTMT
riscv64: https://godbolt.org/z/zTbbnn9x4
arm: https://godbolt.org/z/eK6xWKnrb

Can you rebase D153148 ontop of this. Then create a series on phabricator by using "Edit Related Revision" and making this the child of D153148.

Primary review will be on D153148.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2023, 4:11 AM
This revision was automatically updated to reflect the committed changes.