This is an archive of the discontinued LLVM Phabricator instance.

Differential D154044

[libc] Missing FEnvImpl.h dependency on math.h
ClosedPublic

Authored by phosek on Jun 28 2023, 11:49 PM.

Details

Reviewers
sivachandra
lntue
Commits
rG1c241bb791f9: [libc] Missing FEnvImpl.h dependency on math.h
Summary

FEnvImpl.h includes math.h and so needs an explicit dependency.

Diff Detail

Event Timeline

phosek created this revision.Jun 28 2023, 11:49 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 28 2023, 11:49 PM
Herald added a subscriber: libc-commits. · View Herald Transcript
phosek requested review of this revision.Jun 28 2023, 11:49 PM
Harbormaster completed remote builds in B241985: Diff 535646.Jun 29 2023, 12:10 AM
lntue accepted this revision.Jun 29 2023, 4:41 AM
This revision is now accepted and ready to land.Jun 29 2023, 4:41 AM
Closed by commit rG1c241bb791f9: [libc] Missing FEnvImpl.h dependency on math.h (authored by phosek). · Explain WhyJul 1 2023, 11:27 AM
This revision was automatically updated to reflect the committed changes.
phosek added a commit: rG1c241bb791f9: [libc] Missing FEnvImpl.h dependency on math.h.

Revision Contents

PathSize
libc/
src/
__support/
FPUtil/
1 line

Diff 536544

libc/src/__support/FPUtil/CMakeLists.txt

add_header_library( add_header_library(
fenv_impl fenv_impl
HDRS HDRS
FEnvImpl.h FEnvImpl.h
DEPENDS DEPENDS
libc.include.fenv libc.include.fenv
libc.include.math
libc.src.__support.macros.attributes libc.src.__support.macros.attributes
) )
add_header_library( add_header_library(
rounding_mode rounding_mode
HDRS HDRS
rounding_mode.h rounding_mode.h
DEPENDS DEPENDS
▲ Show 20 Lines • Show All 228 Lines • Show Last 20 Lines