[lldb-vscode] Adjusting CreateSource to detect compiler generated frames.

[ashgti]

A small fix for displaying compiler-generated frames.

[wallace]

pretty nice. Thanks!

lldb/tools/lldb-vscode/JSONUtils.cpp

llvm::json::Value CreateSource(llvm::StringRef source_path) {
   EmplaceSafeString(source, "name", name);
   EmplaceSafeString(source, "path", source_path);
   return llvm::json::Value(std::move(source));
 }
 
 llvm::json::Value CreateSource(lldb::SBFrame &frame, int64_t &disasm_line) {
   disasm_line = 0;
   auto line_entry = frame.GetLineEntry();
-  if (line_entry.GetFileSpec().IsValid())
+  // A line entry of 0 indicates the line is compiler generated i.e. no source
+  // file so don't return early with the line entry.
+  if (line_entry.GetFileSpec().IsValid() && line_entry.GetLine() != 0)
     return CreateSource(line_entry);
 
   llvm::json::Object object;
   const auto pc = frame.GetPC();
 
   lldb::SBInstructionList insts;
   lldb::SBFunction function = frame.GetFunction();
   lldb::addr_t low_pc = LLDB_INVALID_ADDRESS;
if (symbol.IsValid()) {
         disasm_line = g_vsc.GetLineForPC(addr_srcref->second, pc);
       } else {
         insts = symbol.GetInstructions(g_vsc.target);
       }
     }
   }
   const auto num_insts = insts.GetSize();
   if (low_pc != LLDB_INVALID_ADDRESS && num_insts > 0) {
-    EmplaceSafeString(object, "name", frame.GetFunctionName());
+    if (line_entry.GetLine() == 0) {
+      EmplaceSafeString(object, "name", "<compiler-generated>");
+    } else {
+      EmplaceSafeString(object, "name", frame.GetDisplayFunctionName());
+    }
     SourceReference source;
     llvm::raw_string_ostream src_strm(source.content);
     std::string line;
     for (size_t i = 0; i < num_insts; ++i) {
       lldb::SBInstruction inst = insts.GetInstructionAtIndex(i);
       const auto inst_addr = inst.GetAddress().GetLoadAddress(g_vsc.target);
       const char *m = inst.GetMnemonic(g_vsc.target);
       const char *o = inst.GetOperands(g_vsc.target);