This is an archive of the discontinued LLVM Phabricator instance.

alexgatea retitled this revision from [CodeGenModule] Avoid calls to setTargetAttributes on definitions to [NFC] [CodeGenModule] Avoid calls to setTargetAttributes on definitions.Jul 10 2023, 9:35 AM

alexgatea retitled this revision from [NFC] [CodeGenModule] Avoid calls to setTargetAttributes on definitions to [CodeGen][NFCI] Avoid calls to setTargetAttributes on definitions.

alexgatea edited the summary of this revision. (Show Details)Jul 11 2023, 10:39 AM

cebowleratibm mentioned this in rGfb9a74122ef7: [CodeGen][NFCI] Avoid calls to setTargetAttributes on definitions.Jul 12 2023, 6:29 AM

Revision Contents

Path

Size

clang/

lib/

CodeGen/

CodeGenModule.cpp

3 lines

Diff 535071

clang/lib/CodeGen/CodeGenModule.cpp

Context not available.
	}	}
	}	}

	if (GV->isDeclaration()) {	if (D &&
		D->isThisDeclarationADefinition(Context) == VarDecl::DeclarationOnly) {
	getTargetCodeGenInfo().setTargetAttributes(D, GV, *this);	getTargetCodeGenInfo().setTargetAttributes(D, GV, *this);
	// External HIP managed variables needed to be recorded for transformation	// External HIP managed variables needed to be recorded for transformation
	// in both device and host compilations.	// in both device and host compilations.
Context not available.

This is an archive of the discontinued LLVM Phabricator instance.

[CodeGen][NFCI] Avoid calls to setTargetAttributes on definitionsAcceptedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 535071

clang/lib/CodeGen/CodeGenModule.cpp

[CodeGen][NFCI] Avoid calls to setTargetAttributes on definitions
AcceptedPublic