Page MenuHomePhabricator

Switch to gold linker on android x86, x86_64, arm
ClosedPublic

Authored by tberghammer on Dec 9 2015, 6:57 AM.

Details

Summary

Switch to gold linker on android x86, x86_64, arm

These architectures already using the gold linker for the android framework and switching to gold gives us the opportunity to enable ICF.
Safe ICF (identical code folding) reduces the size of an optimized and striped binary by ~5%

Diff Detail

Repository
rL LLVM

Event Timeline

tberghammer updated this revision to Diff 42295.Dec 9 2015, 6:57 AM
tberghammer retitled this revision from to Switch to gold linker on android x86, x86_64, arm.
tberghammer updated this object.
tberghammer added reviewers: labath, ovyalov.
tberghammer added a subscriber: lldb-commits.
labath accepted this revision.Dec 9 2015, 7:01 AM
labath edited edge metadata.

looks good

This revision is now accepted and ready to land.Dec 9 2015, 7:01 AM
ovyalov accepted this revision.Dec 9 2015, 10:30 AM
ovyalov edited edge metadata.

LGTM

cmake/platforms/Android.cmake
124 ↗(On Diff #42295)

Just out of curiosity - you haven't included arm64, it's not supported by gold?

tberghammer added inline comments.Dec 10 2015, 3:05 AM
cmake/platforms/Android.cmake
124 ↗(On Diff #42295)

There were some issues when we tried to change the android framework over to using gold on arm64 so we went back to the default linker util it can get fixed. Most likely it wouldn't affect lldb-server but better to be safe.

This revision was automatically updated to reflect the committed changes.