This is an archive of the discontinued LLVM Phabricator instance.

Differential D153770

Fix test regression on 32-bit x86.
ClosedPublic

Authored by zahiraam on Jun 26 2023, 7:22 AM.

Details

Reviewers
rjmccall
mgorny
Commits
rG9fd3321db742: Fix test regression on 32-bit x86.
Summary

Issue found after merging of patch: https://reviews.llvm.org/D153590

Diff Detail

Event Timeline

zahiraam created this revision.Jun 26 2023, 7:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2023, 7:22 AM
zahiraam requested review of this revision.Jun 26 2023, 7:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2023, 7:22 AM
mgorny added a comment.Jun 26 2023, 8:23 AM

I think you also need to require X86 target but I'm not 100% sure.

zahiraam added a comment.Jun 26 2023, 8:47 AM
In D153770#4449078, @mgorny wrote:

I think you also need to require X86 target but I'm not 100% sure.

I don't think so. That warning was legal and is related to the option ffp-eval-method. I could have added run lines in the LIT test to expect the warnings but that's not the point of the LIT tests here.

mgorny accepted this revision.Jun 26 2023, 8:47 AM

Thanks. I can confirm that this fixes the test failures for me.

This revision is now accepted and ready to land.Jun 26 2023, 8:47 AM
mgorny added a comment.Jun 26 2023, 8:48 AM
In D153770#4449154, @zahiraam wrote:
In D153770#4449078, @mgorny wrote:

I think you also need to require X86 target but I'm not 100% sure.

I don't think so. That warning was legal and is related to the option ffp-eval-method. I could have added run lines in the LIT test to expect the warnings but that's not the point of the LIT tests here.

What I meant is that I think clang might not let you use x86_64 triple without X86 target but I could be wrong.

Harbormaster completed remote builds in B241172: Diff 534550.Jun 26 2023, 9:23 AM
zahiraam updated this revision to Diff 535368.Jun 28 2023, 6:33 AM
Harbormaster completed remote builds in B241768: Diff 535368.Jun 28 2023, 6:58 AM
zahiraam updated this revision to Diff 535783.Jun 29 2023, 7:19 AM
Harbormaster completed remote builds in B242082: Diff 535783.Jun 29 2023, 7:58 AM
This revision was landed with ongoing or failed builds.Jun 29 2023, 8:02 AM
Closed by commit rG9fd3321db742: Fix test regression on 32-bit x86. (authored by zahiraam). · Explain Why
This revision was automatically updated to reflect the committed changes.
zahiraam added a commit: rG9fd3321db742: Fix test regression on 32-bit x86..

Revision Contents

Diff 534550

clang/test/Sema/fp-eval-pragma-with-float-double_t-1.c

// RUN: %clang_cc1 -verify -fsyntax-only -DNOERROR %s // RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only -DNOERROR %s
// RUN: %clang_cc1 -verify -fsyntax-only -x c++ -DCPP -DNOERROR %s // RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only \
// RUN: -x c++ -DCPP -DNOERROR %s
// RUN: %clang_cc1 -verify -fsyntax-only -ffp-eval-method=source -DNOERROR %s
// RUN: %clang_cc1 -verify -fsyntax-only -x c++ -DCPP -ffp-eval-method=source \ // RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only \
// RUN: -ffp-eval-method=source -DNOERROR %s
// RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only -x c++ -DCPP \
// RUN: -ffp-eval-method=source \
// RUN: -DNOERROR %s // RUN: -DNOERROR %s
// RUN: %clang_cc1 -verify -fsyntax-only -ffp-eval-method=double %s // RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only \
// RUN: %clang_cc1 -verify -fsyntax-only -x c++ -DCPP -ffp-eval-method=double %s // RUN: -ffp-eval-method=double %s
// RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only -x c++ -DCPP \
// RUN: -ffp-eval-method=double %s
// RUN: %clang_cc1 -verify -fsyntax-only -ffp-eval-method=extended %s // RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only \
// RUN: %clang_cc1 -verify -fsyntax-only -x c++ -DCPP \ // RUN: -ffp-eval-method=extended %s
// RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only -x c++ -DCPP \
// RUN: -ffp-eval-method=extended %s // RUN: -ffp-eval-method=extended %s
#ifdef NOERROR #ifdef NOERROR
// expected-no-diagnostics // expected-no-diagnostics
typedef float float_t; typedef float float_t;
typedef double double_t; typedef double double_t;
#else #else
▲ Show 20 Lines • Show All 82 Lines • Show Last 20 Lines

clang/test/Sema/fp-eval-pragma-with-float-double_t-2.c

// RUN: %clang_cc1 -verify -fsyntax-only -DNOERROR %s // RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only -DNOERROR %s
// RUN: %clang_cc1 -verify -fsyntax-only -x c++ -DCPP -DNOERROR %s // RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only \
// RUN: -x c++ -DCPP -DNOERROR %s
// RUN: %clang_cc1 -verify -fsyntax-only -ffp-eval-method=double -DNOERROR %s
// RUN: %clang_cc1 -verify -fsyntax-only -x c++ -DCPP -ffp-eval-method=double -DNOERROR %s // RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only \
// RUN: -ffp-eval-method=double -DNOERROR %s
// RUN: %clang_cc1 -verify -fsyntax-only -ffp-eval-method=source %s // RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only -x c++ -DCPP \
// RUN: %clang_cc1 -verify -fsyntax-only -x c++ -DCPP -ffp-eval-method=source %s // RUN: -ffp-eval-method=double -DNOERROR %s
// RUN: %clang_cc1 -verify -fsyntax-only -ffp-eval-method=extended %s // RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only \
// RUN: %clang_cc1 -verify -fsyntax-only -x c++ -DCPP -ffp-eval-method=extended %s // RUN: -ffp-eval-method=source %s
// RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only -x c++ -DCPP \
// RUN: -ffp-eval-method=source %s
// RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only \
// RUN: -ffp-eval-method=extended %s
// RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only -x c++ -DCPP \
// RUN: -ffp-eval-method=extended %s
#ifdef NOERROR #ifdef NOERROR
// expected-no-diagnostics // expected-no-diagnostics
typedef float float_t; typedef float float_t;
typedef double double_t; typedef double double_t;
#else #else
#ifdef CPP #ifdef CPP
typedef float float_t; //expected-error 9 {{cannot use type 'float_t' within '#pragma clang fp eval_method'; type is set according to the default eval method for the translation unit}} typedef float float_t; //expected-error 9 {{cannot use type 'float_t' within '#pragma clang fp eval_method'; type is set according to the default eval method for the translation unit}}
▲ Show 20 Lines • Show All 81 Lines • Show Last 20 Lines

clang/test/Sema/fp-eval-pragma-with-float-double_t-3.c

// RUN: %clang_cc1 -verify -fsyntax-only -verify -DNOERROR %s // RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only -DNOERROR %s
// RUN: %clang_cc1 -verify -fsyntax-only -x c++ -DCPP -DNOERROR %s // RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only \
// RUN: -x c++ -DCPP -DNOERROR %s
// RUN: %clang_cc1 -verify -fsyntax-only -ffp-eval-method=extended -DNOERROR %s // RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only \
// RUN: %clang_cc1 -verify -fsyntax-only -x c++ -DCPP \ // RUN: -ffp-eval-method=extended -DNOERROR %s
// RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only -x c++ -DCPP \
// RUN: -ffp-eval-method=extended -DNOERROR %s // RUN: -ffp-eval-method=extended -DNOERROR %s
// RUN: %clang_cc1 -verify -fsyntax-only -ffp-eval-method=source %s // RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only \
// RUN: %clang_cc1 -verify -fsyntax-only -x c++ -DCPP -ffp-eval-method=source %s // RUN: -ffp-eval-method=source %s
// RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only -x c++ -DCPP \
// RUN: %clang_cc1 -verify -fsyntax-only -ffp-eval-method=double %s // RUN: -ffp-eval-method=source %s
// RUN: %clang_cc1 -verify -fsyntax-only -x c++ -DCPP -ffp-eval-method=double %s
// RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only \
// RUN: -ffp-eval-method=double %s
// RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -fsyntax-only -x c++ -DCPP \
// RUN: -ffp-eval-method=double %s
#ifdef NOERROR #ifdef NOERROR
// expected-no-diagnostics // expected-no-diagnostics
typedef float float_t; typedef float float_t;
typedef double double_t; typedef double double_t;
#else #else
#ifdef CPP #ifdef CPP
▲ Show 20 Lines • Show All 82 Lines • Show Last 20 Lines