This is an archive of the discontinued LLVM Phabricator instance.

[CSKY][NFC][test] Add tests of IR pattern icmp-select
ClosedPublic

Authored by benshi001 on Jun 21 2023, 8:32 AM.

Details

Summary

These tests will be optimized with INCT32/INCF32/DECT32/DECF32
in the future.

Diff Detail

Event Timeline

benshi001 created this revision.Jun 21 2023, 8:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2023, 8:32 AM
benshi001 requested review of this revision.Jun 21 2023, 8:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2023, 8:32 AM
benshi001 updated this revision to Diff 533519.Jun 22 2023, 2:40 AM
zixuan-wu accepted this revision.Jun 29 2023, 11:13 PM

Hope all Pats added are all covered by test.

llvm/test/CodeGen/CSKY/dect-decf.ll
366

Any need to construct such pattern with call? Although, no harm of more test.

This revision is now accepted and ready to land.Jun 29 2023, 11:13 PM
benshi001 added inline comments.Jun 30 2023, 12:12 AM
llvm/test/CodeGen/CSKY/dect-decf.ll
366

This call test is for the Pat

def : Pat<(select CARRY:$ca, (add GPR:$rx, uimm5:$imm), GPR:$false),
          (INCT32 CARRY:$ca, GPR:$false, GPR:$rx, uimm5:$imm)>;
def : Pat<(select CARRY:$ca, GPR:$true, (add GPR:$rx, uimm5:$imm)),
          (INCF32 CARRY:$ca, GPR:$true, GPR:$rx, uimm5:$imm)>;

in https://reviews.llvm.org/D153436, you can see the improvement in this call test at there.

This revision was landed with ongoing or failed builds.Jun 30 2023, 7:55 AM
This revision was automatically updated to reflect the committed changes.