This is an archive of the discontinued LLVM Phabricator instance.

Differential D153374

[libc] Remove disabled pass after performance improvement
ClosedPublic

Authored by jhuber6 on Jun 20 2023, 1:47 PM.

Details

Reviewers
None
Commits
rGee6ace27e0f2: [libc] Remove disabled pass after performance improvement
Summary

This pass used to cause huge compile time regressions, That has been
address and can now be re-added.

Diff Detail

Event Timeline

jhuber6 created this revision.Jun 20 2023, 1:47 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 20 2023, 1:47 PM
Herald added subscribers: libc-commits, kerbowa, jvesely. · View Herald Transcript
jhuber6 requested review of this revision.Jun 20 2023, 1:47 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 20 2023, 1:48 PM
This revision was landed with ongoing or failed builds.
Closed by commit rGee6ace27e0f2: [libc] Remove disabled pass after performance improvement (authored by jhuber6). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhuber6 added a commit: rGee6ace27e0f2: [libc] Remove disabled pass after performance improvement.
Harbormaster completed remote builds in B240086: Diff 533035.Jun 20 2023, 1:53 PM

Revision Contents

PathSize
libc/
startup/
gpu/
amdgpu/
3 lines

Diff 533036

libc/startup/gpu/amdgpu/CMakeLists.txt

Show All 20 Lines
# Ensure that clang uses the correct linker for this object type. # Ensure that clang uses the correct linker for this object type.
target_link_libraries( target_link_libraries(
${fq_name} ${fq_name}
PUBLIC PUBLIC
"-mcpu=${LIBC_GPU_TARGET_ARCHITECTURE}" "-mcpu=${LIBC_GPU_TARGET_ARCHITECTURE}"
"--target=${LIBC_GPU_TARGET_TRIPLE}" "--target=${LIBC_GPU_TARGET_TRIPLE}"
"-flto" "-flto"
"-Wl,-mllvm,-amdgpu-lower-global-ctor-dtor=0" "-Wl,-mllvm,-amdgpu-lower-global-ctor-dtor=0"
# FIXME: This pass causes builds to take ~10x longer. Disable until the
# performance problems have been addressed.
"-Wl,-mllvm,-amdgpu-atomic-optimizations=0"
) )