This is an archive of the discontinued LLVM Phabricator instance.

Differential D153225

[libc++] Marks __cpp_lib_bitops as implemented.
ClosedPublic

Authored by Mordante on Jun 18 2023, 3:38 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rGa4f0764aefd6: [libc++] Marks __cpp_lib_bitops as implemented.
Summary

This FTM was introduced in

P0553R4 Bit operations

Which has been implemented since libc++ 9.

This was noticed while working on D153192.

Diff Detail

Event Timeline

Mordante created this revision.Jun 18 2023, 3:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2023, 3:38 AM
Herald added a subscriber: arichardson. · View Herald Transcript
Mordante requested review of this revision.Jun 18 2023, 3:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2023, 3:38 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B239665: Diff 532464.Jun 18 2023, 7:38 AM
philnik accepted this revision.Jun 18 2023, 4:06 PM
This revision is now accepted and ready to land.Jun 18 2023, 4:06 PM
Closed by commit rGa4f0764aefd6: [libc++] Marks __cpp_lib_bitops as implemented. (authored by Mordante). · Explain WhyJun 19 2023, 8:01 AM
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rGa4f0764aefd6: [libc++] Marks __cpp_lib_bitops as implemented..

Revision Contents

PathSize
libcxx/
docs/
2 lines
include/
2 lines
test/
std/
language.support/
support.limits/
support.limits.general/
48 lines
48 lines
utils/
1 line

Diff 532659

libcxx/docs/FeatureTestMacroTable.rst

Show First 20 Lines • Show All 186 Lines • ▼ Show 20 Lines.. table:: Current Status
``__cpp_lib_atomic_wait`` ``201907L`` ``__cpp_lib_atomic_wait`` ``201907L``
--------------------------------------------------- ----------------- --------------------------------------------------- -----------------
``__cpp_lib_barrier`` ``201907L`` ``__cpp_lib_barrier`` ``201907L``
--------------------------------------------------- ----------------- --------------------------------------------------- -----------------
``__cpp_lib_bind_front`` ``201907L`` ``__cpp_lib_bind_front`` ``201907L``
--------------------------------------------------- ----------------- --------------------------------------------------- -----------------
``__cpp_lib_bit_cast`` ``201806L`` ``__cpp_lib_bit_cast`` ``201806L``
--------------------------------------------------- ----------------- --------------------------------------------------- -----------------
``__cpp_lib_bitops`` *unimplemented* ``__cpp_lib_bitops`` ``201907L``
--------------------------------------------------- ----------------- --------------------------------------------------- -----------------
``__cpp_lib_bounded_array_traits`` ``201902L`` ``__cpp_lib_bounded_array_traits`` ``201902L``
--------------------------------------------------- ----------------- --------------------------------------------------- -----------------
``__cpp_lib_char8_t`` ``201907L`` ``__cpp_lib_char8_t`` ``201907L``
--------------------------------------------------- ----------------- --------------------------------------------------- -----------------
``__cpp_lib_concepts`` ``202002L`` ``__cpp_lib_concepts`` ``202002L``
--------------------------------------------------- ----------------- --------------------------------------------------- -----------------
``__cpp_lib_constexpr_algorithms`` ``201806L`` ``__cpp_lib_constexpr_algorithms`` ``201806L``
▲ Show 20 Lines • Show All 208 Lines • Show Last 20 Lines

libcxx/include/version

Show First 20 Lines • Show All 326 Lines • ▼ Show 20 Lines
# if !defined(_LIBCPP_AVAILABILITY_HAS_NO_SYNC) # if !defined(_LIBCPP_AVAILABILITY_HAS_NO_SYNC)
# define __cpp_lib_atomic_wait 201907L # define __cpp_lib_atomic_wait 201907L
# endif # endif
# if !defined(_LIBCPP_HAS_NO_THREADS) && !defined(_LIBCPP_AVAILABILITY_HAS_NO_SYNC) # if !defined(_LIBCPP_HAS_NO_THREADS) && !defined(_LIBCPP_AVAILABILITY_HAS_NO_SYNC)
# define __cpp_lib_barrier 201907L # define __cpp_lib_barrier 201907L
# endif # endif
# define __cpp_lib_bind_front 201907L # define __cpp_lib_bind_front 201907L
# define __cpp_lib_bit_cast 201806L # define __cpp_lib_bit_cast 201806L
// # define __cpp_lib_bitops 201907L # define __cpp_lib_bitops 201907L
# define __cpp_lib_bounded_array_traits 201902L # define __cpp_lib_bounded_array_traits 201902L
# if !defined(_LIBCPP_HAS_NO_CHAR8_T) # if !defined(_LIBCPP_HAS_NO_CHAR8_T)
# define __cpp_lib_char8_t 201907L # define __cpp_lib_char8_t 201907L
# endif # endif
# define __cpp_lib_concepts 202002L # define __cpp_lib_concepts 202002L
# define __cpp_lib_constexpr_algorithms 201806L # define __cpp_lib_constexpr_algorithms 201806L
# define __cpp_lib_constexpr_complex 201711L # define __cpp_lib_constexpr_complex 201711L
# define __cpp_lib_constexpr_dynamic_alloc 201907L # define __cpp_lib_constexpr_dynamic_alloc 201907L
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines

libcxx/test/std/language.support/support.limits/support.limits.general/bit.version.compile.pass.cpp

Show First 20 Lines • Show All 95 Lines • ▼ Show 20 Lines
# ifndef __cpp_lib_bit_cast # ifndef __cpp_lib_bit_cast
# error "__cpp_lib_bit_cast should be defined in c++20" # error "__cpp_lib_bit_cast should be defined in c++20"
# endif # endif
# if __cpp_lib_bit_cast != 201806L # if __cpp_lib_bit_cast != 201806L
# error "__cpp_lib_bit_cast should have the value 201806L in c++20" # error "__cpp_lib_bit_cast should have the value 201806L in c++20"
# endif # endif
# if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_bitops # ifndef __cpp_lib_bitops
# error "__cpp_lib_bitops should be defined in c++20" # error "__cpp_lib_bitops should be defined in c++20"
# endif # endif
# if __cpp_lib_bitops != 201907L # if __cpp_lib_bitops != 201907L
# error "__cpp_lib_bitops should have the value 201907L in c++20" # error "__cpp_lib_bitops should have the value 201907L in c++20"
# endif # endif
# else // _LIBCPP_VERSION
# ifdef __cpp_lib_bitops
# error "__cpp_lib_bitops should not be defined because it is unimplemented in libc++!"
# endif
# endif
# ifdef __cpp_lib_byteswap # ifdef __cpp_lib_byteswap
# error "__cpp_lib_byteswap should not be defined before c++23" # error "__cpp_lib_byteswap should not be defined before c++23"
# endif # endif
# ifndef __cpp_lib_endian # ifndef __cpp_lib_endian
# error "__cpp_lib_endian should be defined in c++20" # error "__cpp_lib_endian should be defined in c++20"
# endif # endif
Show All 12 Lines
# ifndef __cpp_lib_bit_cast # ifndef __cpp_lib_bit_cast
# error "__cpp_lib_bit_cast should be defined in c++23" # error "__cpp_lib_bit_cast should be defined in c++23"
# endif # endif
# if __cpp_lib_bit_cast != 201806L # if __cpp_lib_bit_cast != 201806L
# error "__cpp_lib_bit_cast should have the value 201806L in c++23" # error "__cpp_lib_bit_cast should have the value 201806L in c++23"
# endif # endif
# if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_bitops # ifndef __cpp_lib_bitops
# error "__cpp_lib_bitops should be defined in c++23" # error "__cpp_lib_bitops should be defined in c++23"
# endif # endif
# if __cpp_lib_bitops != 201907L # if __cpp_lib_bitops != 201907L
# error "__cpp_lib_bitops should have the value 201907L in c++23" # error "__cpp_lib_bitops should have the value 201907L in c++23"
# endif # endif
# else // _LIBCPP_VERSION
# ifdef __cpp_lib_bitops
# error "__cpp_lib_bitops should not be defined because it is unimplemented in libc++!"
# endif
# endif
# ifndef __cpp_lib_byteswap # ifndef __cpp_lib_byteswap
# error "__cpp_lib_byteswap should be defined in c++23" # error "__cpp_lib_byteswap should be defined in c++23"
# endif # endif
# if __cpp_lib_byteswap != 202110L # if __cpp_lib_byteswap != 202110L
# error "__cpp_lib_byteswap should have the value 202110L in c++23" # error "__cpp_lib_byteswap should have the value 202110L in c++23"
# endif # endif
Show All 15 Lines
# ifndef __cpp_lib_bit_cast # ifndef __cpp_lib_bit_cast
# error "__cpp_lib_bit_cast should be defined in c++26" # error "__cpp_lib_bit_cast should be defined in c++26"
# endif # endif
# if __cpp_lib_bit_cast != 201806L # if __cpp_lib_bit_cast != 201806L
# error "__cpp_lib_bit_cast should have the value 201806L in c++26" # error "__cpp_lib_bit_cast should have the value 201806L in c++26"
# endif # endif
# if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_bitops # ifndef __cpp_lib_bitops
# error "__cpp_lib_bitops should be defined in c++26" # error "__cpp_lib_bitops should be defined in c++26"
# endif # endif
# if __cpp_lib_bitops != 201907L # if __cpp_lib_bitops != 201907L
# error "__cpp_lib_bitops should have the value 201907L in c++26" # error "__cpp_lib_bitops should have the value 201907L in c++26"
# endif # endif
# else // _LIBCPP_VERSION
# ifdef __cpp_lib_bitops
# error "__cpp_lib_bitops should not be defined because it is unimplemented in libc++!"
# endif
# endif
# ifndef __cpp_lib_byteswap # ifndef __cpp_lib_byteswap
# error "__cpp_lib_byteswap should be defined in c++26" # error "__cpp_lib_byteswap should be defined in c++26"
# endif # endif
# if __cpp_lib_byteswap != 202110L # if __cpp_lib_byteswap != 202110L
# error "__cpp_lib_byteswap should have the value 202110L in c++26" # error "__cpp_lib_byteswap should have the value 202110L in c++26"
# endif # endif
Show All 16 Lines

libcxx/test/std/language.support/support.limits/support.limits.general/version.version.compile.pass.cpp

Show First 20 Lines • Show All 2,840 Lines • ▼ Show 20 Lines
# ifndef __cpp_lib_bit_cast # ifndef __cpp_lib_bit_cast
# error "__cpp_lib_bit_cast should be defined in c++20" # error "__cpp_lib_bit_cast should be defined in c++20"
# endif # endif
# if __cpp_lib_bit_cast != 201806L # if __cpp_lib_bit_cast != 201806L
# error "__cpp_lib_bit_cast should have the value 201806L in c++20" # error "__cpp_lib_bit_cast should have the value 201806L in c++20"
# endif # endif
# if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_bitops # ifndef __cpp_lib_bitops
# error "__cpp_lib_bitops should be defined in c++20" # error "__cpp_lib_bitops should be defined in c++20"
# endif # endif
# if __cpp_lib_bitops != 201907L # if __cpp_lib_bitops != 201907L
# error "__cpp_lib_bitops should have the value 201907L in c++20" # error "__cpp_lib_bitops should have the value 201907L in c++20"
# endif # endif
# else // _LIBCPP_VERSION
# ifdef __cpp_lib_bitops
# error "__cpp_lib_bitops should not be defined because it is unimplemented in libc++!"
# endif
# endif
# ifdef __cpp_lib_bitset # ifdef __cpp_lib_bitset
# error "__cpp_lib_bitset should not be defined before c++26" # error "__cpp_lib_bitset should not be defined before c++26"
# endif # endif
# ifndef __cpp_lib_bool_constant # ifndef __cpp_lib_bool_constant
# error "__cpp_lib_bool_constant should be defined in c++20" # error "__cpp_lib_bool_constant should be defined in c++20"
# endif # endif
▲ Show 20 Lines • Show All 1,253 Lines • ▼ Show 20 Lines
# ifndef __cpp_lib_bit_cast # ifndef __cpp_lib_bit_cast
# error "__cpp_lib_bit_cast should be defined in c++23" # error "__cpp_lib_bit_cast should be defined in c++23"
# endif # endif
# if __cpp_lib_bit_cast != 201806L # if __cpp_lib_bit_cast != 201806L
# error "__cpp_lib_bit_cast should have the value 201806L in c++23" # error "__cpp_lib_bit_cast should have the value 201806L in c++23"
# endif # endif
# if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_bitops # ifndef __cpp_lib_bitops
# error "__cpp_lib_bitops should be defined in c++23" # error "__cpp_lib_bitops should be defined in c++23"
# endif # endif
# if __cpp_lib_bitops != 201907L # if __cpp_lib_bitops != 201907L
# error "__cpp_lib_bitops should have the value 201907L in c++23" # error "__cpp_lib_bitops should have the value 201907L in c++23"
# endif # endif
# else // _LIBCPP_VERSION
# ifdef __cpp_lib_bitops
# error "__cpp_lib_bitops should not be defined because it is unimplemented in libc++!"
# endif
# endif
# ifdef __cpp_lib_bitset # ifdef __cpp_lib_bitset
# error "__cpp_lib_bitset should not be defined before c++26" # error "__cpp_lib_bitset should not be defined before c++26"
# endif # endif
# ifndef __cpp_lib_bool_constant # ifndef __cpp_lib_bool_constant
# error "__cpp_lib_bool_constant should be defined in c++23" # error "__cpp_lib_bool_constant should be defined in c++23"
# endif # endif
▲ Show 20 Lines • Show All 1,460 Lines • ▼ Show 20 Lines
# ifndef __cpp_lib_bit_cast # ifndef __cpp_lib_bit_cast
# error "__cpp_lib_bit_cast should be defined in c++26" # error "__cpp_lib_bit_cast should be defined in c++26"
# endif # endif
# if __cpp_lib_bit_cast != 201806L # if __cpp_lib_bit_cast != 201806L
# error "__cpp_lib_bit_cast should have the value 201806L in c++26" # error "__cpp_lib_bit_cast should have the value 201806L in c++26"
# endif # endif
# if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_bitops # ifndef __cpp_lib_bitops
# error "__cpp_lib_bitops should be defined in c++26" # error "__cpp_lib_bitops should be defined in c++26"
# endif # endif
# if __cpp_lib_bitops != 201907L # if __cpp_lib_bitops != 201907L
# error "__cpp_lib_bitops should have the value 201907L in c++26" # error "__cpp_lib_bitops should have the value 201907L in c++26"
# endif # endif
# else // _LIBCPP_VERSION
# ifdef __cpp_lib_bitops
# error "__cpp_lib_bitops should not be defined because it is unimplemented in libc++!"
# endif
# endif
# if !defined(_LIBCPP_VERSION) # if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_bitset # ifndef __cpp_lib_bitset
# error "__cpp_lib_bitset should be defined in c++26" # error "__cpp_lib_bitset should be defined in c++26"
# endif # endif
# if __cpp_lib_bitset != 202306L # if __cpp_lib_bitset != 202306L
# error "__cpp_lib_bitset should have the value 202306L in c++26" # error "__cpp_lib_bitset should have the value 202306L in c++26"
# endif # endif
▲ Show 20 Lines • Show All 1,367 Lines • Show Last 20 Lines

libcxx/utils/generate_feature_test_macro_components.py

Show First 20 Lines • Show All 220 Lines • ▼ Show 20 Lines for x in [
"name": "__cpp_lib_bit_cast", "name": "__cpp_lib_bit_cast",
"values": {"c++20": 201806}, "values": {"c++20": 201806},
"headers": ["bit"], "headers": ["bit"],
}, },
{ {
"name": "__cpp_lib_bitops", "name": "__cpp_lib_bitops",
"values": {"c++20": 201907}, "values": {"c++20": 201907},
"headers": ["bit"], "headers": ["bit"],
"unimplemented": True,
}, },
{ {
"name": "__cpp_lib_bitset", "name": "__cpp_lib_bitset",
"values": {"c++26": 202306}, # P2697R1 Interfacing bitset with string_view "values": {"c++26": 202306}, # P2697R1 Interfacing bitset with string_view
"headers": ["bitset"], "headers": ["bitset"],
"unimplemented": True, "unimplemented": True,
}, },
{ {
▲ Show 20 Lines • Show All 1,420 Lines • Show Last 20 Lines