This is an archive of the discontinued LLVM Phabricator instance.

X86-FMA3: Defined ExeDomain for Scalar FMA3 opcodes
ClosedPublic

Authored by v_klochkov on Dec 7 2015, 4:28 PM.

Details

Summary

Please review the patch that defines the ExeDomain for scalar X86-FMA3 opcodes.

The problem was noticed by RKSimon (Simon Pilgrim) in http://reviews.llvm.org/D14762 ( D14762 ).
ExeDomain was defined for packed FMA opcodes, but not defined for scalar FMAs.

This trivial fix in X86InstrFMA.td caused the need in minor changes in 4 LIT tests.

(The same problem for scalar FMA4 opcodes was fixed by Simon Pilgrim just recently (4th of Dec 2015).)

Thank you,
Slava

Diff Detail

Repository
rL LLVM

Event Timeline

v_klochkov updated this revision to Diff 42126.Dec 7 2015, 4:28 PM
v_klochkov retitled this revision from to X86-FMA3: Defined ExeDomain for Scalar FMA3 opcodes.
v_klochkov updated this object.
RKSimon accepted this revision.Dec 8 2015, 4:29 AM
RKSimon edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 8 2015, 4:29 AM
This revision was automatically updated to reflect the committed changes.