This is an archive of the discontinued LLVM Phabricator instance.

[OCaml] Rename link_modules' to link_modules
ClosedPublic

Authored by alan on Jun 15 2023, 6:02 PM.

Details

Summary

Commit 434e956 renamed link_modules to link_modules' for unclear reasons.
Based on the commit's diff, the author possibly intended to have two
functions, link_modules to bind to LLVMLinkModules and link_modules' to
bind to LLVMLinkModules2. However, there is only one function. link_modules'
appears in LLVM 3.8 onwards.

Diff Detail

Event Timeline

alan created this revision.Jun 15 2023, 6:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2023, 6:02 PM
alan requested review of this revision.Jun 15 2023, 6:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2023, 6:02 PM
This revision is now accepted and ready to land.Jun 16 2023, 12:14 AM
This revision was landed with ongoing or failed builds.Jun 16 2023, 6:19 AM
This revision was automatically updated to reflect the committed changes.