This is an archive of the discontinued LLVM Phabricator instance.

Differential D153081

[lsan] Remove use_tls=0 from a few tests
ClosedPublic

Authored by lgrey on Jun 15 2023, 3:39 PM.

Details

Reviewers
vitalybuka
MaskRay
Commits
rG55a2c4eb04b2: [lsan] Remove use_tls=0 from a few tests
Summary

The Objective-C runtime now stashes some state in TLS (https://github.com/apple-oss-distributions/objc4/blob/689525d556eb3dee1ffb700423bccf5ecc501dbf/runtime/objc-initialize.mm#LL139C45-L139C45) so any test that indirectly initializes an Objective-C object will have false positive leaks unless use_tls=1 as is the default.
Example: https://bugs.chromium.org/p/chromium/issues/detail?id=1453649#c3

I removed use_tls=0 unconditionally because it doesn't seem essential to any of these tests. Happy to only do this for Darwin if that doesn't work :)

Diff Detail

Event Timeline

lgrey created this revision.Jun 15 2023, 3:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2023, 3:39 PM
Herald added a subscriber: Enna1. · View Herald Transcript
lgrey requested review of this revision.Jun 15 2023, 3:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2023, 3:39 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B239248: Diff 531921.Jun 15 2023, 3:58 PM
MaskRay accepted this revision.Jun 16 2023, 6:02 PM
This revision is now accepted and ready to land.Jun 16 2023, 6:02 PM
Closed by commit rG55a2c4eb04b2: [lsan] Remove use_tls=0 from a few tests (authored by lgrey). · Explain WhyJun 20 2023, 3:53 PM
This revision was automatically updated to reflect the committed changes.
lgrey added a commit: rG55a2c4eb04b2: [lsan] Remove use_tls=0 from a few tests.

Revision Contents

PathSize
compiler-rt/
test/
lsan/
TestCases/
2 lines
2 lines
2 lines

Diff 533073

compiler-rt/test/lsan/TestCases/disabler.c

// Test for __lsan_disable() / __lsan_enable(). // Test for __lsan_disable() / __lsan_enable().
// RUN: %clang_lsan %s -o %t // RUN: %clang_lsan %s -o %t
// RUN: %env_lsan_opts=report_objects=1:use_registers=0:use_stacks=0:use_tls=0 not %run %t 2>&1 | FileCheck %s // RUN: %env_lsan_opts=report_objects=1:use_registers=0:use_stacks=0 not %run %t 2>&1 | FileCheck %s
// Investigate why it does not fail with use_tls=0 // Investigate why it does not fail with use_tls=0
// UNSUPPORTED: arm-linux || armhf-linux // UNSUPPORTED: arm-linux || armhf-linux
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include "sanitizer/lsan_interface.h" #include "sanitizer/lsan_interface.h"
Show All 15 Lines

compiler-rt/test/lsan/TestCases/disabler.cpp

// Test for ScopedDisabler. // Test for ScopedDisabler.
// RUN: %clangxx_lsan %s -o %t // RUN: %clangxx_lsan %s -o %t
// RUN: %env_lsan_opts=report_objects=1:use_registers=0:use_stacks=0:use_tls=0 not %run %t 2>&1 | FileCheck %s // RUN: %env_lsan_opts=report_objects=1:use_registers=0:use_stacks=0 not %run %t 2>&1 | FileCheck %s
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include "sanitizer/lsan_interface.h" #include "sanitizer/lsan_interface.h"
int main() { int main() {
void **p; void **p;
Show All 13 Lines

compiler-rt/test/lsan/TestCases/ignore_object.c

// Test for __lsan_ignore_object(). // Test for __lsan_ignore_object().
// RUN: %clang_lsan %s -o %t // RUN: %clang_lsan %s -o %t
// RUN: %env_lsan_opts=report_objects=1:use_registers=0:use_stacks=0:use_tls=0 not %run %t 2>&1 | FileCheck %s // RUN: %env_lsan_opts=report_objects=1:use_registers=0:use_stacks=0 not %run %t 2>&1 | FileCheck %s
// Investigate why it does not fail with use_stack=0 // Investigate why it does not fail with use_stack=0
// UNSUPPORTED: arm-linux || armhf-linux // UNSUPPORTED: arm-linux || armhf-linux
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include "sanitizer/lsan_interface.h" #include "sanitizer/lsan_interface.h"
Show All 14 Lines