This is an archive of the discontinued LLVM Phabricator instance.

[libc++abi] Avoid including source files into unittest_demangle
ClosedPublic

Authored by ldionne on Jun 13 2023, 2:58 PM.

Details

Summary

That is not necessary to test what we're testing, and in fact including
abort_message.cpp into that file caused some link errors if we didn't
link some of the dependencies of libc++abi directly into the test.

Diff Detail

Event Timeline

ldionne created this revision.Jun 13 2023, 2:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2023, 2:58 PM
ldionne requested review of this revision.Jun 13 2023, 2:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2023, 2:58 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
nickdesaulniers accepted this revision.Jun 14 2023, 8:08 AM

Sorry about that! Thanks for the patch!

ldionne accepted this revision as: Restricted Project.Jun 15 2023, 8:44 AM
This revision is now accepted and ready to land.Jun 15 2023, 8:44 AM