[libc++][NFC] Reformat params.py

[ldionne]

Summary

After the Black reformatting changes, the code became pretty hard to
read and inconsistently formatted. This fixes that.

[ldionne]

Poke CI

[ldionne]

Poke CI

libcxx/utils/libcxx/test/params.py

 
 
 def getModuleFlag(cfg, enable_modules):
     if enable_modules in _allModules:
         return enable_modules
     return None
 
 
+# fmt: off
 DEFAULT_PARAMETERS = [
     Parameter(
         name="target_triple",
         type=str,
         help="The target triple to compile the test suite for. This must be "
         "compatible with the target that the tests will be run on.",
         actions=lambda triple: filter(
             None,
Parameter(
         choices=_allModules,
         type=str,
         help="Whether to build the test suite with modules enabled. Select "
         "`clang` for Clang modules and `std` for C++23 std module",
         default=lambda cfg: next(s for s in _allModules if getModuleFlag(cfg, s)),
         actions=lambda enable_modules: [
             AddFeature("modules-build"),
             AddCompileFlag("-fmodules"),
-            AddCompileFlag(
-                "-fcxx-modules"
-            ),  # AppleClang disregards -fmodules entirely when compiling C++. This enables modules for C++.
+            AddCompileFlag("-fcxx-modules"), # AppleClang disregards -fmodules entirely when compiling C++. This enables modules for C++.
         ]
         if enable_modules == "clang"
         else [
             AddFeature("use_module_std"),
             AddCompileFlag("-DTEST_USE_MODULE"),
             AddCompileFlag("-DTEST_USE_MODULE_STD"),
             AddCompileFlag(
                 lambda cfg: "-fprebuilt-module-path="
                 + os.path.join(
                     cfg.test_exec_root, "__config_module__/CMakeFiles/std.dir"
                 )
             ),
             BuildStdModule(),
         ]
         if enable_modules == "std"
         else [],
     ),
     Parameter(
         name="enable_modules_lsv",
         choices=[True, False],
         type=bool,
         default=False,
         help="Whether to enable Local Submodule Visibility in the Modules build.",
-        actions=lambda lsv: [
+        actions=lambda lsv: [] if not lsv else [
             AddCompileFlag("-Xclang -fmodules-local-submodule-visibility"),
-        ]
-        if lsv
-        else [],
+        ],
     ),
     Parameter(
         name="enable_exceptions",
         choices=[True, False],
         type=bool,
         default=True,
         help="Whether to enable exceptions when compiling the test suite.",
-        actions=lambda exceptions: []
-        if exceptions
-        else [AddFeature("no-exceptions"), AddCompileFlag("-fno-exceptions")],
+        actions=lambda exceptions: [] if exceptions else [
+            AddFeature("no-exceptions"),
+            AddCompileFlag("-fno-exceptions")
+        ],
     ),
     Parameter(
         name="enable_rtti",
         choices=[True, False],
         type=bool,
         default=True,
         help="Whether to enable RTTI when compiling the test suite.",
-        actions=lambda rtti: []
-        if rtti
-        else [AddFeature("no-rtti"), AddCompileFlag("-fno-rtti")],
+        actions=lambda rtti: [] if rtti else [
+            AddFeature("no-rtti"),
+            AddCompileFlag("-fno-rtti")
+        ],
     ),
     Parameter(
         name="stdlib",
         choices=["llvm-libc++", "apple-libc++", "libstdc++", "msvc"],
         type=str,
         default="llvm-libc++",
         help="""The C++ Standard Library implementation being tested.
 
Parameter(
                  - msvc: The Microsoft implementation of the C++ Standard Library.
                 """,
         actions=lambda stdlib: filter(
             None,
             [
                 AddFeature("stdlib={}".format(stdlib)),
                 # Also add an umbrella feature 'stdlib=libc++' for all flavors of libc++, to simplify
                 # the test suite.
-                AddFeature("stdlib=libc++")
-                if re.match(".+-libc\+\+", stdlib)
-                else None,
+                AddFeature("stdlib=libc++") if re.match(".+-libc\+\+", stdlib) else None,
             ],
         ),
     ),
     Parameter(
         name="enable_warnings",
         choices=[True, False],
         type=bool,
         default=True,
         help="Whether to enable warnings when compiling the test suite.",
-        actions=lambda warnings: []
-        if not warnings
-        else [AddOptionalWarningFlag(w) for w in _warningFlags]
-        + [AddCompileFlag("-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER")],
+        actions=lambda warnings: [] if not warnings else
+            [AddOptionalWarningFlag(w) for w in _warningFlags] +
+            [AddCompileFlag("-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER")],
     ),
     Parameter(
         name="use_sanitizer",
         choices=[
             "",
             "Address",
             "HWAddress",
             "Undefined",
             "Memory",
             "MemoryWithOrigins",
             "Thread",
             "DataFlow",
             "Leaks",
         ],
         type=str,
         default="",
         help="An optional sanitizer to enable when building and running the test suite.",
         actions=lambda sanitizer: filter(
             None,
             [
                 AddFlag("-g -fno-omit-frame-pointer") if sanitizer else None,
-                AddFlag(
-                    "-fsanitize=undefined -fno-sanitize=float-divide-by-zero -fno-sanitize-recover=all"
-                )
-                if sanitizer == "Undefined"
-                else None,
-                AddFeature("ubsan") if sanitizer == "Undefined" else None,
+
+                AddFlag("-fsanitize=undefined -fno-sanitize=float-divide-by-zero -fno-sanitize-recover=all") if sanitizer == "Undefined" else None,
+                AddFeature("ubsan")                                                                          if sanitizer == "Undefined" else None,
+
                 AddFlag("-fsanitize=address") if sanitizer == "Address" else None,
-                AddFeature("asan") if sanitizer == "Address" else None,
+                AddFeature("asan")            if sanitizer == "Address" else None,
+
                 AddFlag("-fsanitize=hwaddress") if sanitizer == "HWAddress" else None,
-                AddFeature("hwasan") if sanitizer == "HWAddress" else None,
-                AddFlag("-fsanitize=memory")
-                if sanitizer in ["Memory", "MemoryWithOrigins"]
-                else None,
-                AddFeature("msan")
-                if sanitizer in ["Memory", "MemoryWithOrigins"]
-                else None,
-                AddFlag("-fsanitize-memory-track-origins")
-                if sanitizer == "MemoryWithOrigins"
-                else None,
+                AddFeature("hwasan")            if sanitizer == "HWAddress" else None,
+
+                AddFlag("-fsanitize=memory")               if sanitizer in ["Memory", "MemoryWithOrigins"] else None,
+                AddFeature("msan")                         if sanitizer in ["Memory", "MemoryWithOrigins"] else None,
+                AddFlag("-fsanitize-memory-track-origins") if sanitizer == "MemoryWithOrigins" else None,
+
                 AddFlag("-fsanitize=thread") if sanitizer == "Thread" else None,
-                AddFeature("tsan") if sanitizer == "Thread" else None,
+                AddFeature("tsan")           if sanitizer == "Thread" else None,
+
                 AddFlag("-fsanitize=dataflow") if sanitizer == "DataFlow" else None,
-                AddFlag("-fsanitize=leaks") if sanitizer == "Leaks" else None,
-                AddFeature("sanitizer-new-delete")
-                if sanitizer
-                in ["Address", "HWAddress", "Memory", "MemoryWithOrigins", "Thread"]
-                else None,
-            ],
-        ),
+                AddFlag("-fsanitize=leaks")    if sanitizer == "Leaks" else None,
+
+                AddFeature("sanitizer-new-delete") if sanitizer in ["Address", "HWAddress", "Memory", "MemoryWithOrigins", "Thread"] else None,
+            ]
+        )
     ),
     Parameter(
         name="enable_experimental",
         choices=[True, False],
         type=bool,
         default=True,
         help="Whether to enable tests for experimental C++ Library features.",
         actions=lambda experimental: [
             # When linking in MSVC mode via the Clang driver, a -l<foo>
             # maps to <foo>.lib, so we need to use -llibc++experimental here
             # to make it link against the static libc++experimental.lib.
             # We can't check for the feature 'msvc' in available_features
             # as those features are added after processing parameters.
             AddFeature("c++experimental"),
-            PrependLinkFlag(
-                lambda cfg: "-llibc++experimental"
-                if _isMSVC(cfg)
-                else "-lc++experimental"
-            ),
+            PrependLinkFlag(lambda cfg: "-llibc++experimental" if _isMSVC(cfg) else "-lc++experimental"),
             AddCompileFlag("-D_LIBCPP_ENABLE_EXPERIMENTAL"),
         ]
         if experimental
         else [
             AddFeature("libcpp-has-no-incomplete-pstl"),
         ],
     ),
     Parameter(
         name="long_tests",
         choices=[True, False],
         type=bool,
         default=True,
         help="Whether to enable tests that take longer to run. This can be useful when running on a very slow device.",
         actions=lambda enabled: [] if not enabled else [AddFeature("long_tests")],
     ),
     Parameter(
         name="enable_assertions",
         choices=[True, False],
         type=bool,
         default=False,
         help="Whether to enable assertions when compiling the test suite. This is only meaningful when "
         "running the tests against libc++.",
-        actions=lambda assertions: [
+        actions=lambda assertions: [] if not assertions else [
             AddCompileFlag("-D_LIBCPP_ENABLE_ASSERTIONS=1"),
             AddFeature("libcpp-has-assertions"),
-        ]
-        if assertions
-        else [],
+        ],
     ),
     Parameter(
         name="additional_features",
         type=list,
         default=[],
         help="A comma-delimited list of additional features that will be enabled when running the tests. "
         "This should be used sparingly since specifying ad-hoc features manually is error-prone and "
         "brittle in the long run as changes are made to the test suite.",
         actions=lambda features: [AddFeature(f) for f in features],
     ),
     Parameter(
         name="enable_transitive_includes",
         choices=[True, False],
         type=bool,
         default=True,
         help="Whether to enable backwards-compatibility transitive includes when running the tests. This "
         "is provided to ensure that the trimmed-down version of libc++ does not bit-rot in between "
         "points at which we bulk-remove transitive includes.",
-        actions=lambda enabled: []
-        if enabled
-        else [
+        actions=lambda enabled: [] if enabled else [
             AddFeature("transitive-includes-disabled"),
             AddCompileFlag("-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES"),
         ],
     ),
 ]
+# fmt: on