This is an archive of the discontinued LLVM Phabricator instance.

[scudo] Fix MallocIterateBoundary on 32 bit.
ClosedPublic

Authored by cferris on Jun 12 2023, 7:03 PM.

Details

Summary

On Android, the 32 bit value of 8 for BlockDelta results in a
failure because a valid pointer can never be found.

Change the code to always use 16 which passes on both 32 bit
and 64 bit.

Verified that re-introducing the old bug causes the test to fail
on both 32 bit and 64 with the new BlockDelta value.

Diff Detail

Event Timeline

cferris created this revision.Jun 12 2023, 7:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 7:03 PM
Herald added subscribers: yaneury, Enna1. · View Herald Transcript
cferris requested review of this revision.Jun 12 2023, 7:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 7:03 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Chia-hungDuan accepted this revision.Jun 12 2023, 7:08 PM
This revision is now accepted and ready to land.Jun 12 2023, 7:08 PM
This revision was automatically updated to reflect the committed changes.