This is an archive of the discontinued LLVM Phabricator instance.

Differential D152711

[test][ASAN] Fix incorrect REQUIRES directive for scandir.c
ClosedPublic

Authored by justincady on Jun 12 2023, 8:01 AM.

Details

Reviewers
ro
emaste
Commits
rG10e1d5080977: [test][ASAN] Fix incorrect REQUIRES directive for scandir.c
Summary

The missing colon caused the test to run on unintended platforms.

Diff Detail

Event Timeline

justincady created this revision.Jun 12 2023, 8:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 8:01 AM
Herald added a subscriber: Enna1. · View Herald Transcript
justincady requested review of this revision.Jun 12 2023, 8:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 8:01 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
justincady mentioned this in D151583: [ASAN] Fix validation size for dirent on FreeBSD.Jun 12 2023, 8:04 AM
emaste accepted this revision.Jun 12 2023, 8:08 AM
This revision is now accepted and ready to land.Jun 12 2023, 8:08 AM
justincady added a comment.Jun 12 2023, 8:11 AM

Thank you for taking a look, @emaste ! I'll get this in to resolve the buildbot issue mentioned by @ro in https://reviews.llvm.org/D151583 .

This revision was landed with ongoing or failed builds.Jun 12 2023, 8:17 AM
Closed by commit rG10e1d5080977: [test][ASAN] Fix incorrect REQUIRES directive for scandir.c (authored by justincady). · Explain Why
This revision was automatically updated to reflect the committed changes.
justincady added a commit: rG10e1d5080977: [test][ASAN] Fix incorrect REQUIRES directive for scandir.c.
Harbormaster completed remote builds in B238193: Diff 530511.Jun 12 2023, 8:30 AM

Revision Contents

PathSize
compiler-rt/
test/
sanitizer_common/
TestCases/
2 lines

Diff 530515

compiler-rt/test/sanitizer_common/TestCases/scandir.c

// REQUIRES (linux && !android) || freebsd // REQUIRES: (linux && !android) || freebsd
// RUN: rm -rf %t-dir // RUN: rm -rf %t-dir
// RUN: mkdir -p %t-dir // RUN: mkdir -p %t-dir
// RUN: touch %t-dir/a %t-dir/b %t-dir/c // RUN: touch %t-dir/a %t-dir/b %t-dir/c
// RUN: %clang %s -DTEMP_DIR='"'"%t-dir"'"' -o %t && %run %t 2>&1 // RUN: %clang %s -DTEMP_DIR='"'"%t-dir"'"' -o %t && %run %t 2>&1
#include <dirent.h> #include <dirent.h>
Show All 17 Lines