Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D152699

[libc++][spaceship] P1614R2: Removed `operator!=` from `weekday`s
ClosedPublic
Actions

Authored by H-G-Hristov on Jun 12 2023, 4:32 AM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rG0029ad89e8c7: [libc++][spaceship] P1614R2: Removed `operator!=` from `weekday`s
Summary

Implements parts of P1614R2. Removed operator!= from:

  • weekday
  • weekday_indexed
  • weekday_last
  • month_weekday
  • month_weekday_last
  • year_month_weekday
  • year_month_weekday_last

Note these operators were added and removed in C++20.

Diff Detail

Event Timeline

H-G-Hristov created this revision.Jun 12 2023, 4:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 4:32 AM
Herald added a subscriber: yaxunl. · View Herald Transcript
H-G-Hristov updated this revision to Diff 530463.Jun 12 2023, 4:44 AM

Rebased + implementation

H-G-Hristov edited the summary of this revision. (Show Details)Jun 12 2023, 4:47 AM
Harbormaster completed remote builds in B238157: Diff 530463.Jun 12 2023, 7:47 AM
H-G-Hristov published this revision for review.Jun 12 2023, 7:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 7:57 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Mordante accepted this revision.Jun 12 2023, 9:26 AM
Mordante edited the summary of this revision. (Show Details)
Mordante added a subscriber: Mordante.

LGTM! I added a note to the commit message, please land with the new text.

This revision is now accepted and ready to land.Jun 12 2023, 9:26 AM
Closed by commit rG0029ad89e8c7: [libc++][spaceship] P1614R2: Removed `operator!=` from `weekday`s (authored by Zingam). · Explain WhyJun 12 2023, 12:22 PM
This revision was automatically updated to reflect the committed changes.
Zingam added a commit: rG0029ad89e8c7: [libc++][spaceship] P1614R2: Removed `operator!=` from `weekday`s.

Revision Contents
Changeset List

PathSize
libcxx/
docs/
Status/
14 lines
include/
__chrono/
9 lines
13 lines
9 lines
9 lines

Diff 530634

View Options

libcxx/docs/Status/SpaceshipProjects.csv

Loading...
View Options

libcxx/include/__chrono/month_weekday.h

Loading...
View Options

libcxx/include/__chrono/weekday.h

Loading...
View Options

libcxx/include/__chrono/year_month_weekday.h

Loading...
View Options

libcxx/include/chrono

Loading...